Repository navigation
feat(sveltekit): Send the render start of a cached page to the browser - #26398
Merged
Merged
Conversation
Contributor
size-limit report 📦Compared: 630bc56 (PR test merge using develop at deebe83) Against: deebe83 (develop) · base run #66286 ✅ Baseline matches: this diff contains only this PR's changes.
|
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 4 not successful, 59 successful. See the run.
Successful checks
|
Member
Author
|
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 0aceb4e. Configure here.
s1gr1d
enabled stacked auto-merge (squash)
November 16, 2026 13:05
stacked auto-merge was automatically disabled
November 16, 2026 13:06
Auto-merge was disabled for another pull request in the stack
chargome
approved these changes
Nov 16, 2026
s1gr1d
force-pushed
the
sig/sveltekit-cacheComponents-ticket-20
branch
2 times, most recently
from
November 16, 2026 14:47
8d25564 to
66647eb
Compare
Base automatically changed from
sig/nextjs-cacheComponents-ticket-20
to
develop
November 16, 2026 15:05
SvelteKit now writes a `sentry-render-start` meta tag next to `sentry-cache-origin` on prerendered and Vercel ISR pages, so the browser can set `page.server_rendering.age` on the pageload span. Kit calls `transformPageChunk` only after the whole render, so the tag holds the request start that `sentryHandle` records when no span records.
s1gr1d
force-pushed
the
sig/sveltekit-cacheComponents-ticket-20
branch
from
November 16, 2026 15:06
66647eb to
46f1beb
Compare
s1gr1d
enabled stacked auto-merge (squash)
November 16, 2026 15:06
s1gr1d
added a commit
that referenced
this pull request
Nov 16, 2026
…6399) Stacked on #26398. ## What Nuxt now writes the `sentry-render-start` meta tag next to `sentry-cache-origin` on cached and prerendered pages. The browser sets `page.server_rendering.age` from it, as in #26397. ## Why The tag holds the start of the linked render span. Without a recording span, it holds the request start. Nitro calls `render:html` only after the whole render, so a Nitro `request` hook records the start on `event.context`. The hook also fires for prerender requests, and a background SWR revalidation sees the context of the request that started it. On Cloudflare, this also gives the right start when the async context is lost.
51 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #26397.
What
SvelteKit now writes the
sentry-render-startmeta tag next tosentry-cache-originon prerendered and Vercel ISR pages. The browser setspage.server_rendering.agefrom it, as in #26397.Why
The tag holds the start of the linked render span. Without a recording span (build prerender, unsampled request), it holds the request start that
sentryHandlerecords. The current time would be too late by the whole render, because Kit callstransformPageChunkonly after the render._INTERNAL_getCacheOriginMetaTagsis the new shared writer for both tags. The old_INTERNAL_getCacheOriginMetaTagstays until Nuxt moves to the new one in the next PR.