Skip to content

chore(ci): Add Warden gha-security-review and skill-scanner - #26269

Merged
mydea merged 2 commits into
developfrom
feat/warden-gha-skill-scanner
Nov 11, 2026
Merged

mydea merged 2 commits into
developfrom
feat/warden-gha-skill-scanner

Conversation

@sentry-junior

@sentry-junior sentry-junior Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Why: The org-wide Warden workflow (getsentry/.github) only runs security-review here. We have ~25 workflows, several of which drive AI agents (auto-fix-issue, dependabot-auto-triage, track-framework-updates, optional-e2e), plus ~20 agent skills managed via agents.toml. This adds a repo warden.toml that layers two more skills on top of the org base: gha-security-review (from getsentry/skills) for .github/workflows/** and .github/actions/**, and the already-vendored skill-scanner for .agents/**, .claude/**, .cursor/**, and agents.toml/agents.lock. sentry-dotnet and sentry-python run the same skills.

failOn = "high" matches most getsentry repos; with failCheck and requestChanges left at their false defaults, findings are still reported only and never block merges. Each skill is scoped with explicit paths because repo-layer skills don't inherit the org ignorePaths. model is left unset so it inherits the org default; the org workflow only provides an OpenRouter key.

How to review: Single config file. I validated it with @sentry/warden@0.53.0 (loadWardenConfig + resolveSkillConfigs), and both skills resolve (local skill-scanner, remote gha-security-review). It hasn't run end-to-end in CI yet. Since this PR touches neither workflows nor skills, neither new skill should trigger on it.

Unsure about: Whether .cursor/** (BUGBOT.md, environment.json) belongs in skill-scanner scope. I included it because it's agent instructions.

via Francesco Gringl-Novy.

--

View Session [Sentry]

The org-wide Warden workflow only runs security-review. Add a repo
warden.toml that also reviews GitHub workflow changes and agent skill
changes, scoped by paths since repo skills don't inherit org ignorePaths.

Co-Authored-By: Francesco Gringl-Novy <francesco.novy@sentry.io>
@github-actions

github-actions Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

size-limit report 📦

Compared: 462b2b1 (PR test merge using develop at 44a9081)

Against: 44a9081 (develop) · base run #65604

✅ Baseline matches: this diff contains only this PR's changes.

Path Size % Change Change
@sentry/browser 29.92 kB - -
@sentry/browser - with treeshaking flags 28.08 kB - -
@sentry/browser - with treeshaking flags tracing without tracing 27.97 kB - -
@sentry/browser (incl. Tracing) 52.29 kB - -
@sentry/browser (incl. Tracing + Span Streaming) 52.3 kB - -
@sentry/browser (incl. Tracing, Profiling) 55.27 kB - -
@sentry/browser (incl. Tracing, Replay) 92.7 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 81.37 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 97.43 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 110.42 kB - -
@sentry/browser (incl. Feedback) 47.52 kB - -
@sentry/browser (incl. sendFeedback) 35.02 kB - -
@sentry/browser (incl. FeedbackAsync) 40.13 kB - -
@sentry/browser (incl. Metrics) 31.48 kB - -
@sentry/browser (incl. Logs) 31.77 kB - -
@sentry/browser (incl. Metrics & Logs) 32.45 kB - -
@sentry/react 31.78 kB - -
@sentry/react (incl. Tracing) 54.76 kB - -
@sentry/vue 38.33 kB - -
@sentry/vue (incl. Tracing) 55.33 kB - -
@sentry/svelte 29.95 kB - -
@sentry/remix (Remix 3 client bundle) 57.92 kB - -
CDN Bundle 31.72 kB - -
CDN Bundle (incl. Tracing) 52.89 kB - -
CDN Bundle (incl. Logs, Metrics) 34.52 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) 55.39 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) 76 kB - -
CDN Bundle (incl. Tracing, Replay) 91.17 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 93.72 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 97.3 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 99.89 kB - -
CDN Bundle - uncompressed 92.76 kB - -
CDN Bundle (incl. Tracing) - uncompressed 156.02 kB - -
CDN Bundle (incl. Logs, Metrics) - uncompressed 101.29 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 163.79 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 233.18 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 278.04 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 285.8 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 291.74 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 299.5 kB - -
@sentry/nextjs (client) 57.73 kB - -
@sentry/sveltekit (client) 52.82 kB - -
@sentry/core/server 44.51 kB - -
@sentry/core/browser 14.02 kB - -
@sentry/node 157.79 kB +0.01% +15 B 🔺
@sentry/node/import (ESM hook with diagnostics-channel injection) 82.31 kB - -
@sentry/node - without tracing 97.23 kB +0.02% +18 B 🔺
@sentry/node - without channel injection 138.11 kB +0.02% +19 B 🔺
@sentry/aws-serverless 106.08 kB +0.03% +24 B 🔺
@sentry/cloudflare (withSentry) - minified 203.81 kB - -
@sentry/cloudflare (withSentry) 506.45 kB - -
@sentry/nextjs/cloudflare (withSentry) - minified 225.49 kB - -

View base workflow run

Co-Authored-By: Francesco Gringl-Novy <francesco.novy@sentry.io>
@mydea mydea self-assigned this Nov 11, 2026
@mydea
mydea marked this pull request as ready for review November 11, 2026 07:54
@mydea
mydea requested review from a team, JPeer264, msonnb, s1gr1d and stephanie-anderson and removed request for stephanie-anderson November 11, 2026 07:54
@mydea
mydea merged commit 29f7386 into develop Nov 11, 2026
47 checks passed
@mydea
mydea deleted the feat/warden-gha-skill-scanner branch November 11, 2026 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants