Repository navigation
chore(ci): Add Warden gha-security-review and skill-scanner - #26269
Merged
Merged
Conversation
The org-wide Warden workflow only runs security-review. Add a repo warden.toml that also reviews GitHub workflow changes and agent skill changes, scoped by paths since repo skills don't inherit org ignorePaths. Co-Authored-By: Francesco Gringl-Novy <francesco.novy@sentry.io>
Contributor
size-limit report 📦Compared: 462b2b1 (PR test merge using develop at 44a9081) Against: 44a9081 (develop) · base run #65604 ✅ Baseline matches: this diff contains only this PR's changes.
|
Co-Authored-By: Francesco Gringl-Novy <francesco.novy@sentry.io>
mydea
marked this pull request as ready for review
November 11, 2026 07:54
mydea
requested review from
a team,
JPeer264,
msonnb,
s1gr1d and
stephanie-anderson
and removed request for
stephanie-anderson
November 11, 2026 07:54
msonnb
approved these changes
Nov 11, 2026
51 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: The org-wide Warden workflow (
getsentry/.github) only runssecurity-reviewhere. We have ~25 workflows, several of which drive AI agents (auto-fix-issue,dependabot-auto-triage,track-framework-updates,optional-e2e), plus ~20 agent skills managed viaagents.toml. This adds a repowarden.tomlthat layers two more skills on top of the org base:gha-security-review(fromgetsentry/skills) for.github/workflows/**and.github/actions/**, and the already-vendoredskill-scannerfor.agents/**,.claude/**,.cursor/**, andagents.toml/agents.lock. sentry-dotnet and sentry-python run the same skills.failOn = "high"matches most getsentry repos; withfailCheckandrequestChangesleft at theirfalsedefaults, findings are still reported only and never block merges. Each skill is scoped with explicitpathsbecause repo-layer skills don't inherit the orgignorePaths.modelis left unset so it inherits the org default; the org workflow only provides an OpenRouter key.How to review: Single config file. I validated it with
@sentry/warden@0.53.0(loadWardenConfig+resolveSkillConfigs), and both skills resolve (localskill-scanner, remotegha-security-review). It hasn't run end-to-end in CI yet. Since this PR touches neither workflows nor skills, neither new skill should trigger on it.Unsure about: Whether
.cursor/**(BUGBOT.md, environment.json) belongs in skill-scanner scope. I included it because it's agent instructions.via Francesco Gringl-Novy.
--
View Session [Sentry]