Repository navigation
feat(aws-serverless): Ignore static asset and preflight invocations by default - #26228
Merged
Merged
Conversation
Contributor
size-limit report 📦Compared: 20054f3 (PR test merge using develop at edae47f) Against: 187ee90 (develop) · base run #65693
|
mydea
marked this pull request as ready for review
November 10, 2026 10:50
sentry-junior
Bot
force-pushed
the
feat/aws-serverless-ignore-static-assets
branch
from
November 10, 2026 10:51
5132fd7 to
04c80d4
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 04c80d4. Configure here.
sentry-junior
Bot
force-pushed
the
feat/aws-serverless-ignore-static-assets
branch
from
November 10, 2026 11:01
9ae809e to
f767c45
Compare
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 4 not successful, 53 successful. See the run.
Successful checks
|
Base automatically changed from
feat/aws-serverless-http-event-attributes
to
develop
November 11, 2026 14:19
…y default A browser hitting a Lambda Function URL also fetches /favicon.ico, which shows up as a second function.aws trace that looks like a duplicate. Add default ignoreSpans filters that drop the invocations http.server spans skip by default: GET requests for static assets and metadata files, and OPTIONS/HEAD requests. User-provided ignoreSpans are kept. Refs JS-4029 Co-Authored-By: Francesco Gringl-Novy <francesco.novy@sentry.io>
mydea
force-pushed
the
feat/aws-serverless-ignore-static-assets
branch
from
November 11, 2026 14:19
e16638d to
c3c36f2
Compare
msonnb
approved these changes
Nov 11, 2026
51 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Why: When a browser opens a Lambda Function URL, it also fetches
/favicon.ico. That shows up as a secondfunction.awstrace that looks like a duplicate (#25813).init()now adds defaultignoreSpansfilters for the invocationshttp.serverspans skip by default: GET requests for static assets and metadata files (the same list asisStaticAssetRequestin core), and OPTIONS/HEAD requests. Filters users pass in are kept.How to review: This is stacked on #26226 because the filters match on the
http.request.methodandurl.pathattributes added there. Retarget todeveloponce that one merges.Unsure about: Static asset filtering can be turned off with
ignoreStaticAssets: false, the same ashttp.server. OPTIONS/HEAD are always skipped. The regex duplicates core'sisStaticAssetRequestbecauseignoreSpansonly takes patterns, not functions.Refs #25813
via Francesco Gringl-Novy.
--
View Session [Sentry]