Repository navigation
perf(ci): cache WebKit system package downloads - #26198
Conversation
Co-Authored-By: OpenAI Codex <codex@openai.com>
size-limit report 📦Compared: 7e0bcdf (PR test merge using develop at 3577370) Against: 3577370 (develop) · base run #65530 ✅ Baseline matches: this diff contains only this PR's changes.
|
Co-Authored-By: OpenAI Codex <codex@openai.com>
Optional E2E testsSome optional checks were not successful. They do not block the merge. 6 not successful, 51 successful. See the run.
Successful checks
|
Co-Authored-By: OpenAI Codex <codex@openai.com>
Co-Authored-By: OpenAI Codex <codex@openai.com>
Co-Authored-By: OpenAI Codex <codex@openai.com>
| # Resolve now and install after restoring the cache; share the package list across both steps. | ||
| printf '%s\n' "${packages[@]}" > "$RUNNER_TEMP/webkit-apt-packages" | ||
| # runner.temp is private, so keep installers where apt's sandbox user can access them. | ||
| mkdir -p /var/tmp/webkit-apt-cache |
There was a problem hiding this comment.
Clanker reported The real install would then fail with E: Archives directory .../partial is missing, which would break every WebKit job. The fix is mkdir -p /var/tmp/webkit-apt-cache/partial. Might be worth double checking, I'm also triggering bugbot here
There was a problem hiding this comment.
bugbot seems okay with it and I threw my agent at testing it locally and seems to not be an issue as far as I could tell
|
buglitzer moch |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit d0a1e27. Configure here.
Co-Authored-By: OpenAI Codex <codex@openai.com>
Why: We recently reduced browser system-package downloads by an estimated 6GB per full CI run. WebKit still needs about 29MB per job, and those remaining downloads can occasionally take over 15 minutes (recently happened in around 10-15% of runs). This change caches the installers so warm jobs fetch them from GitHub’s cache instead of Ubuntu mirrors reducing the risk of hitting slow downloads. The cache is saved on develop and then restored on PR runs.