Repository navigation
ci: Remove codecov reporting - #20803
Merged
Merged
Conversation
This does not work really well for us anyhow as tests are really fragmented etc.
Contributor
size-limit report 📦
|
mydea
marked this pull request as ready for review
May 12, 2026 07:28
mydea
requested review from
a team,
chargome and
nicohrubec
and removed request for
a team
May 12, 2026 07:28
andreiborza
approved these changes
May 12, 2026
nicohrubec
approved these changes
May 12, 2026
47 tasks
s1gr1d
added a commit
that referenced
this pull request
Nov 17, 2026
…26458) ## What - The lockfile check ignores `deprecated:` lines in `pnpm-lock.yaml`. - WebKit jobs skip Playwright's host validation. - Vitest does not collect coverage or write a junit report by default. Use `vitest --coverage` to collect coverage. ## Why I went through the CI logs of the last month (601 `develop` runs, 294 of them not green). These three causes are not in test code: - When a maintainer deprecates a locked version on npm, pnpm wants to add a `deprecated:` line to the lockfile. "Check lockfile" then failed on `develop` without a change in the repo, in 19 runs, until someone committed the line. - WebKit only starts while the cached browser folder holds Playwright's `DEPENDENCIES_VALIDATED` marker, which is valid for 30 days. The cache is from 2026-11-04, so all WebKit jobs would fail from 2026-12-04. Jobs with a failed cache restore failed already on 11-16 and 11-17. The action installs only the libraries that headless WebKit needs, so the full validation cannot pass. - Nothing reads the coverage or junit output since #20803. Coverage makes the `@sentry/core` tests about 3x slower (66 s against 24 s locally), and slow unit tests timed out on busy runners. Vitest adds the `github-actions` reporter by itself, so the annotations stay. `pnpm run dedupe-deps:check` still fails on a new deprecation, because I did not change `package.json`. The WebKit change needs a CI job without the cached marker to prove it. First PR of a stack of four.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This does not work really well for us as tests are really fragmented etc, so the coverage is always incomplete. a lot of stuff is covered in e2e tests which are not measured, etc. With this we can safe some (?) processing on CI that we are not really using.