Repository navigation
[material_ui] Add Material 3 Expressive TextButton - #13732
Draft
QuncCccccc wants to merge 6 commits into
Draft
QuncCccccc wants to merge 6 commits into
QuncCccccc wants to merge 6 commits into
Conversation
Each iteration changes the theme-level size, and before the theme animation finishes the button still uses the previous size, so the test only built xSmall buttons.
Text buttons can't be toggle buttons, so the button template no longer gives their Material 3 Expressive defaults a toggleable parameter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to add Material 3 Expressive support to
TextButton. As withElevatedButton(#13084), apps opt in withTextButtonThemeData(variant: StyleVariant.material3Expressive). Without it,TextButtonkeeps the Material 3 style.With Material 3 Expressive, text buttons support:
ButtonStyle.sizeVariant): extra small through extra large. Each size has its own height, padding, icon size, label text style, and gap between the icon and the label.ButtonStyle.shapeVariant): round and square, including the pressed shape.md.comp.button.text.disabled.container.color.Text buttons don't get
isSelected. Material 3 Expressive has no toggle text buttons ("There is no toggle text button" in the Material 3 button specs), and the text button tokens have no selected or unselected values.The defaults are generated from the Material Design tokens by
ButtonTemplateM3E. Because text buttons can't be toggle buttons, the template no longer gives their defaults atoggleableparameter.SegmentedButtonbuilds its segments withTextButton, and the properties that its segment style doesn't set, such as padding, come from theTextButtondefaults. Without a change, opting text buttons into Material 3 Expressive would change the padding of its segments.SegmentedButtondoesn't have a Material 3 Expressive style, so its internalTextButtonThemenow setsvariant: StyleVariant.material3, and its segments keep the Material 3TextButtondefaults.New APIs:
TextButtonThemeData.variantandTextButtonTheme.variantOf. A theme that doesn't specifyvariantinherits it from the enclosing themes, the same way asElevatedButtonThemeData.variant.sizeVariantandshapeVariantparameters forTextButton.styleFrom.Part of flutter/flutter#184937
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2