Skip to content

[material_ui] Migrate TextField, TextFormField, SelectableText, TextSelectionTheme, and SearchDelegate API doc snippets to {@example} (batch 17) - #13729

Draft
dkwingsmt wants to merge 1 commit into
flutter:mainfrom
dkwingsmt:snippet_material_text_search
Draft

dkwingsmt wants to merge 1 commit into
flutter:mainfrom
dkwingsmt:snippet_material_text_search

Conversation

@dkwingsmt

Copy link
Copy Markdown
Contributor

This PR addresses batch 17 of the migration detailed in flutter/flutter#188530 (comment).

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2

…electionTheme, and SearchDelegate API doc snippets to {@example} (batch 17)
@dkwingsmt
dkwingsmt marked this pull request as draft November 19, 2026 21:27
@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Nov 19, 2026
@github-actions github-actions Bot added p: material_ui triage-design Should be looked at in design triage labels Nov 19, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request extracts inline code snippets from documentation comments into standalone example files and adds corresponding unit tests for several widgets, including SearchDelegate, SelectableText, TextField, TextFormField, and TextSelectionTheme. Feedback is provided on the TextField buildCounter snippet to handle the nullable maxLength parameter gracefully, preventing the string 'null' from being displayed when no maximum length is specified.

Comment on lines +16 to +19
return Text(
'$currentLength of $maxLength characters',
semanticsLabel: 'character count',
);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The maxLength parameter is nullable (int?). If maxLength is null, string interpolation will display '0 of null characters', which is a poor user experience. It is better to handle the null case gracefully by only displaying the current length when maxLength is not provided.

Suggested change
return Text(
'$currentLength of $maxLength characters',
semanticsLabel: 'character count',
);
return Text(
maxLength == null ? '$currentLength characters' : '$currentLength of $maxLength characters',
semanticsLabel: 'character count',
);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD p: material_ui triage-design Should be looked at in design triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant