Skip to content

[material_ui] Migrate Tab, TabController, DefaultTabController, and DrawerController API doc snippets to {@example} (batch 16) - #13728

Draft
dkwingsmt wants to merge 1 commit into
flutter:mainfrom
dkwingsmt:snippet_material_tab_drawer
Draft

dkwingsmt wants to merge 1 commit into
flutter:mainfrom
dkwingsmt:snippet_material_tab_drawer

Conversation

@dkwingsmt

@dkwingsmt dkwingsmt commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

This PR addresses batch 16 of the migration detailed in flutter/flutter#188530 (comment).

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2

…rawerController API doc snippets to {@example} (batch 16)
@dkwingsmt
dkwingsmt marked this pull request as draft November 19, 2026 21:24
@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Nov 19, 2026
@github-actions github-actions Bot added p: material_ui triage-design Should be looked at in design triage labels Nov 19, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request extracts inline code snippets from the documentation comments of DrawerController, DefaultTabController, TabController, and Tab into separate example files and adds corresponding widget tests. A review comment suggests avoiding the null-assertion operator on tab.text in the TabController example to prevent potential runtime exceptions when a tab uses a custom child instead of text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD p: material_ui triage-design Should be looked at in design triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant