Skip to content

[material_ui] Migrate Slider and SliderTheme API doc snippets to {@example} (batch 13) - #13723

Open
dkwingsmt wants to merge 2 commits into
flutter:mainfrom
dkwingsmt:snippet_material_slider
Open

dkwingsmt wants to merge 2 commits into
flutter:mainfrom
dkwingsmt:snippet_material_slider

Conversation

@dkwingsmt

Copy link
Copy Markdown
Contributor

This PR addresses batch 13 of the migration detailed in flutter/flutter#188530 (comment).

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Nov 19, 2026
@github-actions github-actions Bot added p: material_ui triage-design Should be looked at in design triage labels Nov 19, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request extracts inline code snippets from the documentation of Slider, SliderTheme, and SliderThemeData into separate snippet files under the example directory, referencing them via {@example} tags, and adds corresponding widget tests. The review feedback suggests making the State classes (LaunchState and BlissfulState) private in the newly added slider theme snippet files to align with Flutter conventions.

Comment on lines +10 to +17
class Launch extends StatefulWidget {
const Launch({super.key});

@override
State<Launch> createState() => LaunchState();
}

class LaunchState extends State<Launch> {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

In Flutter, State classes should be private to prevent exposing internal state representation and polluting the public API namespace. Consider renaming LaunchState to _LaunchState.

Suggested change
class Launch extends StatefulWidget {
const Launch({super.key});
@override
State<Launch> createState() => LaunchState();
}
class LaunchState extends State<Launch> {
class Launch extends StatefulWidget {
const Launch({super.key});
@override
State<Launch> createState() => _LaunchState();
}
class _LaunchState extends State<Launch> {

Comment on lines +10 to +17
class Blissful extends StatefulWidget {
const Blissful({super.key});

@override
State<Blissful> createState() => BlissfulState();
}

class BlissfulState extends State<Blissful> {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

In Flutter, State classes should be private to prevent exposing internal state representation and polluting the public API namespace. Consider renaming BlissfulState to _BlissfulState.

Suggested change
class Blissful extends StatefulWidget {
const Blissful({super.key});
@override
State<Blissful> createState() => BlissfulState();
}
class BlissfulState extends State<Blissful> {
class Blissful extends StatefulWidget {
const Blissful({super.key});
@override
State<Blissful> createState() => _BlissfulState();
}
class _BlissfulState extends State<Blissful> {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD p: material_ui triage-design Should be looked at in design triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant