Repository navigation
Conversation
Signed-off-by: Srinivas Chippagiri <cvas22@gmail.com>
- Add the port parameter to the table (default 443). The LocalStack
example already uses it.
- Say in the tls row that a plain HTTP endpoint also needs port set,
because the port stays 443 when tls is off.
- Pad both rows to the table's existing column widths.
Signed-off-by: Eric D. Schabell <eric@schabell.org>
eschabell
left a comment
There was a problem hiding this comment.
@cvas22 thanks for the docs PR, really appreciate it! I've added a small follow on adjustment but it's ready to go. There is one issue I'm bookmarking here for action when the code PR merges, so no action needed now from you!
Still open before merge this PR
- The
tlsrow needs a version qualifier ("In vX or later"). Released versions ignoretlson this plugin, andtls onfails with "does not support TLS". I left it out
because #12602 has no milestone yet. Once the target release is known, add the sentence and the matching version label here.
|
Follow-up commit b2a5715 adds a port row and updates the tls row. With tls: off, a plain HTTP endpoint usually also needs a non-default port, such as 4566 for LocalStack. The plugin already reads port (default 443) and passes it to the upstream connection. That option has existed since v2.1.0 (fluent/fluent-bit@9efd3532a) but was never in the parameter table. The tls row now tells readers to set port along with tls: off. The port row doesn't depend on fluent/fluent-bit#12602. The tls row still does, so this PR keeps waiting on that merge. |
Docs for fluent/fluent-bit#12602, which makes
cloudwatch_logshonortls. It used to stay on TLS whatever you set.This adds
tlsto the parameter table (defaulton) and setstls: offin the LocalStack example, since that endpoint is plain HTTP and the example wouldn't connect otherwise.Summary by CodeRabbit