Skip to content

Plan to move to a modular 1.0 #220

Open

Description

@mafiosso

According to jashkenas/underscore#2771 (comment), these changes are planned:

  1. Fix things so that development is smooth again.
  2. Check existing issues and PRs for things that might be best addressed before modularization.
  3. Release version 0.4.
  4. Modularize.
  5. Release version 0.5.
  6. Complete any missing documentation and unittests.
  7. Release version 1.0.

Activity

  1. jgonggrijp commented on Jul 9, 2020

    @jgonggrijp
    Contributor

    Hey folks, nice to introduce! I'll add some background to the above information.

    Since quite recently, I've become actively involved in Underscore. My most significant contributions so far are the move to ES module notation (jashkenas/underscore#2826, released in version 1.10) and chopping everything into single function modules (jashkenas/underscore#2849, upcoming version 1.11). I plan to give Underscore-contrib a similar treatment, which is what step 4 above refers to.

    I'm working on a new library that will depend on both modular Underscore and modular Contrib, which is the first reason for me to come up with the above plan. Besides that, I also believe that a thriving, up-to-date Contrib will benefit the Underscore community at large. For both reasons, I plan to continue helping to maintain Contrib after the above plan has completed.

    I previously contacted @fogus and @joshuacc about this resurrection plan and they both responded positively.

    Now that we have this ticket in place, we can use it to keep track of the progress. Stage 1 just started with a pull request by @mafiosso, which I'll review shortly. Some time will pass before I start contributing code myself, as I'm currently still preparing the Underscore 1.11 release.

  2. changed the title [-]Maintenance changes - moving towards v1.0[/-] [+]Plan to move to a modular 1.0[/+] on Jul 9, 2020
  3. jgonggrijp commented on Aug 3, 2020

    @jgonggrijp
    Contributor

    The above PR by @mafiosso completed stage 1, so we're at stage 2 now. As a first step, I have created temporary "before modules" and "after modules" labels, which I'll be applying in a large triaging sweep over all open issues and PRs.

    The "before modules" label will mark everything that needs to be done during stage 2, at a minimum. The "after modules" label will mark everything that is better left until after stage 4. If an issue or PR gets neither label, it does not matter whether it is taken up before or after stage 4, although the "before modules" label indicates higher priority.

    I'll report back here when the triage sweep is done.

  4. mafiosso commented on Aug 4, 2020

    @mafiosso
    ContributorAuthor

    The above PR by @mafiosso completed stage 1, so we're at stage 2 now. As a first step, I have created temporary "before modules" and "after modules" labels, which I'll be applying in a large triaging sweep over all open issues and PRs.

    The "before modules" label will mark everything that needs to be done during stage 2, at a minimum. The "after modules" label will mark everything that is better left until after stage 4. If an issue or PR gets neither label, it does not matter whether it is taken up before or after stage 4, although the "before modules" label indicates higher priority.

    I'll report back here when the triage sweep is done.

    Hi @jgonggrijp thank you for this activity, I'll check the PRs soon and leave some comments about it's functionality and maturity to merge, if you agree.

  5. jgonggrijp commented on Aug 4, 2020

    @jgonggrijp
    Contributor

    @mafiosso I agree, please do!

  6. jgonggrijp commented on Aug 7, 2020

    @jgonggrijp
    Contributor

    Triage sweep is done. The remainder of stage 2 is a matter of processing all the "before modules" tickets.

    @mafiosso Thanks a lot for your reviews so far! In those cases where you think that a PR should be merged, but still requires some work, please feel free to submit a continuation PR as well if it suits you.

  7. jgonggrijp commented on Aug 29, 2020

    @jgonggrijp
    Contributor

    Quick update: as some may have noticed, my activity in this repo has ramped up during the past weeks. Today (or yesterday, depending on your time zone), we released Underscore 1.11, so Contrib will have my undivided attention from now on, at least as far as the open source share of my time is concerned.

    Some links: version 1.11 release notes, article, TLDR article. The clickable modular annotated source gives a nice impression of where we're heading with Contrib.

    Right now, we are still at stage 2, but I think we'll be able to move on to the next steps quite soon.

  8. jgonggrijp commented on Oct 15, 2020

    @jgonggrijp
    Contributor

    I took a hiatus to work on some things for the 1.12 release of Underscore core. Resuming now.

  9. jgonggrijp commented on Oct 30, 2020

    @jgonggrijp
    Contributor

    At this point, the only steps left in stage 2 are CI/CD (#188 and #228, to be closed together in #230 which is ready for review) and four old PRs that need some minor fixes in order to be merged (#135, #199, #208, #214). If nobody does it before me, I'll finish those PRs after #230 has been merged, so I can run the CI tests on them before merging. While waiting for review on #230, I'll work a bit on the Fusion library.

  10. jgonggrijp commented on Dec 18, 2020

    @jgonggrijp
    Contributor

    #230 was merged and stage 2 is nearly complete. There are just two old PRs left, one of which already has a complete follow-up that is ready for review (#240). We should reach the 0.4 release quite soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions