Repository navigation
Conversation
rumpl
force-pushed
the
feat/compact-tui-activity
branch
from
November 13, 2026 23:36
e1d31ed to
3b475f7
Compare
This comment was marked as outdated.
This comment was marked as outdated.
rumpl
force-pushed
the
feat/compact-tui-activity
branch
from
November 14, 2026 00:00
1816795 to
dc7cc7b
Compare
rumpl
force-pushed
the
feat/compact-tui-activity
branch
from
November 14, 2026 00:07
4083936 to
f3b4e0b
Compare
rumpl
force-pushed
the
feat/compact-tui-activity
branch
from
November 14, 2026 00:10
f3b4e0b to
c36d378
Compare
rumpl
force-pushed
the
feat/compact-tui-activity
branch
from
November 14, 2026 00:20
c36d378 to
5453e05
Compare
rumpl
force-pushed
the
feat/compact-tui-activity
branch
from
November 14, 2026 00:22
5453e05 to
a636ad6
Compare
rumpl
force-pushed
the
feat/compact-tui-activity
branch
from
November 14, 2026 00:32
a636ad6 to
215a2a6
Compare
rumpl
force-pushed
the
feat/compact-tui-activity
branch
from
November 14, 2026 00:55
215a2a6 to
a02c5db
Compare
Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
rumpl
force-pushed
the
feat/compact-tui-activity
branch
from
November 14, 2026 01:02
a02c5db to
c6efc9e
Compare
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The viewport, mouse capture, and scrollback changes require real-terminal validation of resizing, Shift-selection/scrolling, approval visibility, and exit cleanup; string-output tests cannot establish those behaviors.
No open issues 🎉
1 resolved since last review
Review effort: Balanced
trungutt
approved these changes
Nov 14, 2026
rumpl
marked this pull request as draft
November 14, 2026 22:26
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
edit_filecalls, errors, and approval prompts outside routine summaries.