Skip to content

feat: add expandable compact activity summaries to both TUIs - #4928

Draft
rumpl wants to merge 1 commit into
docker:mainfrom
rumpl:feat/compact-tui-activity
Draft

rumpl wants to merge 1 commit into
docker:mainfrom
rumpl:feat/compact-tui-activity

Conversation

@rumpl

@rumpl rumpl commented Nov 13, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Add a persistent Compact activity setting to both TUIs, disabled by default.
  • Summarize consecutive routine tool calls with tool names/counts and running progress instead of showing all arguments, output, and reasoning.
  • Click a summary to expand or collapse details. Keep the summary above the expanded calls and preserve normal spacing between tool boxes.
  • Always show edit_file calls, errors, and approval prompts outside routine summaries.
  • Enable mouse clicks only in compact mode in the lean TUI, preserving expansion as tools finish and restoring terminal mouse state on exit. Hold Shift for native terminal selection and scrolling.

@rumpl
rumpl requested a review from a team as a code owner November 13, 2026 23:30
Copilot AI balanced review requested due to automatic review settings November 13, 2026 23:30
@rumpl
rumpl force-pushed the feat/compact-tui-activity branch from e1d31ed to 3b475f7 Compare November 13, 2026 23:36

This comment was marked as outdated.

Copilot AI balanced review requested due to automatic review settings November 13, 2026 23:37

This comment was marked as outdated.

Copilot AI balanced review requested due to automatic review settings November 13, 2026 23:56
@rumpl

This comment was marked as outdated.

@rumpl
rumpl force-pushed the feat/compact-tui-activity branch from 1816795 to dc7cc7b Compare November 14, 2026 00:00
@aheritier aheritier added area/docs Documentation changes area/tui For features/issues/fixes related to the TUI kind/feat PR adds a new feature (maps to feat:). Use on PRs only. labels Nov 14, 2026

This comment was marked as outdated.

Copilot AI balanced review requested due to automatic review settings November 14, 2026 00:02
@rumpl
rumpl force-pushed the feat/compact-tui-activity branch from 4083936 to f3b4e0b Compare November 14, 2026 00:07

This comment was marked as outdated.

Copilot AI balanced review requested due to automatic review settings November 14, 2026 00:08
@rumpl
rumpl force-pushed the feat/compact-tui-activity branch from f3b4e0b to c36d378 Compare November 14, 2026 00:10

This comment was marked as outdated.

Copilot AI balanced review requested due to automatic review settings November 14, 2026 00:14

This comment was marked as outdated.

@rumpl
rumpl force-pushed the feat/compact-tui-activity branch from c36d378 to 5453e05 Compare November 14, 2026 00:20
Copilot AI balanced review requested due to automatic review settings November 14, 2026 00:20
@rumpl
rumpl force-pushed the feat/compact-tui-activity branch from 5453e05 to a636ad6 Compare November 14, 2026 00:22

This comment was marked as outdated.

Copilot AI balanced review requested due to automatic review settings November 14, 2026 00:26

This comment was marked as outdated.

@rumpl
rumpl force-pushed the feat/compact-tui-activity branch from a636ad6 to 215a2a6 Compare November 14, 2026 00:32
Copilot AI balanced review requested due to automatic review settings November 14, 2026 00:32

This comment was marked as outdated.

@rumpl
rumpl force-pushed the feat/compact-tui-activity branch from 215a2a6 to a02c5db Compare November 14, 2026 00:55
Copilot AI balanced review requested due to automatic review settings November 14, 2026 00:55

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Expanded standalone activity groups omit the normal separator before a following transfer_task, causing inconsistent delegation-card spacing.

1 open issue
1 resolved since last review

Review effort: Balanced

Comment thread pkg/tui/components/messages/messages.go Resolved
Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
@rumpl
rumpl force-pushed the feat/compact-tui-activity branch from a02c5db to c6efc9e Compare November 14, 2026 01:02
Copilot AI balanced review requested due to automatic review settings November 14, 2026 01:02

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The viewport, mouse capture, and scrollback changes require real-terminal validation of resizing, Shift-selection/scrolling, approval visibility, and exit cleanup; string-output tests cannot establish those behaviors.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

@rumpl
rumpl marked this pull request as draft November 14, 2026 22:26

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/docs Documentation changes area/tui For features/issues/fixes related to the TUI kind/feat PR adds a new feature (maps to feat:). Use on PRs only.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants