Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
There are no active review issues blocking the CI race-test mitigation.
No open issues 🎉
What changed in this PR
Temporarily mitigates the TypeScript generator’s Linux CI race-test failures associated with golang/go#81122. The change isolates that package with GOMAXPROCS=1 while keeping race detection enabled for every package; it does not fix the upstream issue.
Changes:
- Splits CI race testing into ordinary packages and a separate generator run, validating package discovery first.
- Adds a dedicated CI task without changing the existing
test-racetask. - Adds mocked shell regression tests for package selection, environment isolation, and failure handling, and runs them in CI.
| File | Description |
|---|---|
Taskfile.yml |
Adds the test-race-ci task using the test environment. |
scripts/test-race-ci.sh |
Separates race-test runs and limits only the generator to GOMAXPROCS=1. |
scripts/test-race-ci-test.sh |
Tests package discovery, command arguments, environment isolation, and failures. |
.github/workflows/ci.yml |
Runs the shell regression tests and switches the race job to the dedicated CI task. |
Review effort: Balanced
aheritier
enabled auto-merge
November 13, 2026 19:50
trungutt
approved these changes
Nov 14, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Nov 14, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Linux CI, set
GOMAXPROCS=1only for race tests of the TypeScript generator package as a temporary mitigation for golang/go#81122. Race checks remain enabled for every package. This is not an upstream fix; track the issue separately: #4804, #4805, #4806, #4807, #4810, #4873, #4874, #4890.Validation:
task buildandtask testpassed.task lintfailed on three errcheck findings in untouched files using local golangci-lint 2.15.0 (CI uses 2.14.0).