Repository navigation
refactor(catalog): add api_flavor classification - #4818
Open
onatozmenn wants to merge 1 commit into
Open
onatozmenn wants to merge 1 commit into
onatozmenn wants to merge 1 commit into
Conversation
Signed-off-by: onatozmenn <onatozmen44@gmail.com>
onatozmenn
force-pushed
the
catalog/api-flavor
branch
from
November 9, 2026 10:01
cc3b168 to
a3d8d53
Compare
onatozmenn
marked this pull request as ready for review
November 9, 2026 10:01
Contributor
Author
|
Hey @rumpl, quick ping on this one. I rebased it on main and the catalog tests pass locally. CI is still waiting for approval. No rush at all, just checking if the api_flavor direction is what you had in mind before I take it further. Happy to rename things or close it if not. |
Member
|
Update, didn't have the time yet to look at this one, will try today |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small first slice for #4756, mostly to check the shape before touching runtime behavior.
What it does:
api_flavorto the provider catalog:openai,openai-compatible, orgateway.openai_vendor: trueproviders (openai,chatgpt,azure) asopenai.mistralasopenai-compatibleandopenrouterasgatewayas representative examples.openai_vendor: trueprovider must beapi_flavor: openai.What it intentionally does not do:
openai_vendoror any runtime behavior yet.The idea is to keep
api_typeas the transport/client and useapi_flavorfor the semantic distinction, so a gateway or a compatible provider is not mistaken for a first-party OpenAI endpoint. Happy to adjust the naming or drop this if you would rather go a different way.Follow-up to #4755. Refs #4756.