Skip to content

refactor(catalog): add api_flavor classification - #4818

Open
onatozmenn wants to merge 1 commit into
docker:mainfrom
onatozmenn:catalog/api-flavor
Open

onatozmenn wants to merge 1 commit into
docker:mainfrom
onatozmenn:catalog/api-flavor

Conversation

@onatozmenn

Copy link
Copy Markdown
Contributor

This is a small first slice for #4756, mostly to check the shape before touching runtime behavior.

What it does:

  • Adds api_flavor to the provider catalog: openai, openai-compatible, or gateway.
  • Classifies the current openai_vendor: true providers (openai, chatgpt, azure) as openai.
  • Adds mistral as openai-compatible and openrouter as gateway as representative examples.
  • Adds tests for the classification and an invariant that any openai_vendor: true provider must be api_flavor: openai.

What it intentionally does not do:

  • It does not change openai_vendor or any runtime behavior yet.
  • It does not classify every provider. Once the direction is agreed, the remaining catalog entries and the behavior gates can move over.

The idea is to keep api_type as the transport/client and use api_flavor for the semantic distinction, so a gateway or a compatible provider is not mistaken for a first-party OpenAI endpoint. Happy to adjust the naming or drop this if you would rather go a different way.

Follow-up to #4755. Refs #4756.

Copilot AI balanced review requested due to automatic review settings November 5, 2026 15:05

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@aheritier aheritier added area/providers For features/issues/fixes related to LLM providers (Bedrock, LiteLLM, Qwen, custom, etc.) kind/refactor PR refactors code without behavior change labels Nov 5, 2026
Signed-off-by: onatozmenn <onatozmen44@gmail.com>
Copilot AI balanced review requested due to automatic review settings November 9, 2026 10:01
@onatozmenn
onatozmenn marked this pull request as ready for review November 9, 2026 10:01
@onatozmenn
onatozmenn requested a review from a team as a code owner November 9, 2026 10:01

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@onatozmenn

Copy link
Copy Markdown
Contributor Author

Hey @rumpl, quick ping on this one. I rebased it on main and the catalog tests pass locally. CI is still waiting for approval. No rush at all, just checking if the api_flavor direction is what you had in mind before I take it further. Happy to rename things or close it if not.

@aheritier aheritier left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The classification matches this metadata-only slice of #4756 without changing runtime behavior. Tests cover all five classified providers, allowed flavor values, and the OpenAI-vendor invariant. No findings.

@rumpl

rumpl commented Nov 13, 2026

Copy link
Copy Markdown
Member

Update, didn't have the time yet to look at this one, will try today

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/providers For features/issues/fixes related to LLM providers (Bedrock, LiteLLM, Qwen, custom, etc.) kind/refactor PR refactors code without behavior change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants