Repository navigation
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
The egress allowlist blocks Helm updates for several widely used public chart repositories. Dependabot then misses new releases, including security patches, while the update job still reports success. Example from a Helm update job:
This PR adds five exact chart-repository hosts to the
helmlist:istio-release.storage.googleapis.com(Istio; index and tarballs under/charts/)charts.konghq.com(Kong; tarballs on github.com)aws.github.io(AWS eks-charts, secrets-store-csi-driver-provider-aws)charts.fairwinds.com(Fairwinds,/stable/)open-policy-agent.github.io(OPA Gatekeeper)Anything you want to highlight for special attention from reviewers?
istio-release.storage.googleapis.comis a virtual-hosted GCS bucket. Following the file's GCS policy (as withmaven-central), it is added as one exact, vendor-owned bucket; the*.storage.googleapis.comclass stays blocked. Every entry is an exact host, with no*.github.iowildcard.How will you know you've accomplished your goal?
I added positive probes for each host's
index.yamland negativeevil.<host>subdomain probes to the egress allowlist tests.go test ./internal/handlers -run TestEgresspasses.Checklist