Skip to content

fix: preserve PowerPoint field text when extracting links - #13377

Merged
anakin87 merged 2 commits into
deepset-ai:mainfrom
gauravch-code:fix/pptx-field-text
Oct 22, 2026
Merged

anakin87 merged 2 commits into
deepset-ai:mainfrom
gauravch-code:fix/pptx-field-text

Conversation

@gauravch-code

@gauravch-code gauravch-code commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Related issue

fixes #13370.

Changes

Preserve PowerPoint field values when extracting Markdown or
plain-text links, including fields inside table cells.

Adds regression tests and a release note. Line-break behavior
is unchanged; #13222 addresses that separately.

Testing

  • All 18 PowerPoint converter tests pass.
  • Four regression cases failed before the fix.
  • Focused type checks and applicable pre-commit checks pass.

AI assistance

Codex helped investigate the issue

@gauravch-code
gauravch-code requested a review from a team as a code owner October 21, 2026 19:24
@gauravch-code
gauravch-code requested review from davidsbatista and removed request for a team October 21, 2026 19:24
@vercel

vercel Bot commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

@gauravch-code is attempting to deploy a commit to the deepset Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  haystack/components/converters
  pptx.py
  haystack/core/pipeline
  pipeline.py
Project Total  

This report was generated by python-coverage-comment-action

@github-actions github-actions Bot added the type:documentation Improvements on the docs label Oct 22, 2026

@anakin87 anakin87 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

I pushed some minor refinements

@anakin87
anakin87 enabled auto-merge (squash) October 22, 2026 09:28
@anakin87
anakin87 merged commit 03c009d into deepset-ai:main Oct 22, 2026
22 of 23 checks passed
bogdankostic added a commit to Rainmemery/haystack that referenced this pull request Nov 11, 2026
Resolve conflicts with deepset-ai#12768 (grouped shapes and tables) and deepset-ai#13377 (field
text): keep main's paragraph-child walk and field handling in
`_process_paragraph` and add the soft line break branch on top of it; keep
both sets of tests.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic:tests type:documentation Improvements on the docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PPTXToDocument: line breaks become \v or are dropped, and field text is lost with link extraction

2 participants