Repository navigation
Pin notebooks to published dandiset versions - #216
Open
bendichter wants to merge 1 commit into
Open
bendichter wants to merge 1 commit into
bendichter wants to merge 1 commit into
Conversation
Notebooks that read a dandiset's draft (or its latest published version implicitly) now name a published version, so re-uploads to the draft or a new release cannot change the data under them. Each pin is the dandiset's most recent published version. Notebooks with a dandiset ID variable get a matching dandiset_version/DANDISET_VERSION variable; the shared stream_nwbfile helpers take the version as an argument. For 000971 and 001550 the draft files changed after the last release, so these notebooks now read the published files; the rest read files identical to their draft. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Contributor
Index page previewA preview of the generated Last updated: commit |
Contributor
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #214. Notebooks that read a dandiset's draft broke when the draft was re-uploaded (001636, 001754). This pins every other notebook that can be pinned to its dandiset's most recent published version, so neither draft edits nor a new release change the data under it.
Notebooks with a
dandiset_id/DANDISET_IDvariable get a matchingdandiset_version/DANDISET_VERSION; calls with a literal ID get a literal version. The sharedstream_nwbfilehelpers (000458, 000559, 000971) take the version as an argument, defaulting to"draft"for outside callers. The 000055, 000402 and 001075 helpers name the version directly.0.230223.12160.220127.04360.241017.1444dandi downloadURL)0.231012.21290.230307.21320.260309.13240.230317.00390.260528.08580.251111.2151tutorials/bcm_2024)0.260825.19020.240106.00430.240827.18090.240510.22110.261013.17070.241111.17190.240930.18590.241023.20110.260528.10160.260129.08290.260916.08110.260825.14570.220126.1853,0.221208.1803Get-to-know-a-Dandisettutorial"Identical" means every asset path has the same blob in the draft and the published version, so pinning changes nothing today.
Not pinned:
dandi/DANDI User Guide, Part I: lets the reader switch between four dandisets.demos/NWBWidget-demo: the reader picks the dandiset./draftlanding pages are left as they are.Tested: the 000971 and 001550 notebooks (whose data changes) execute end to end on the pinned versions. CI runs the rest of the changed, CI-tested notebooks.
🤖 Generated with Claude Code