Skip to content

Golden capture: leave the PR's runs alone; show the capture as a commit status - #6261

Merged
shai-almog merged 5 commits into
masterfrom
golden-capture-no-cancel
Nov 17, 2026
Merged

shai-almog merged 5 commits into
masterfrom
golden-capture-no-cancel

Conversation

@shai-almog

Copy link
Copy Markdown
Collaborator

A golden capture cancelled every run of the PR (unit tests, CodeQL, doc builds) for the hours its legs took, and its own runs are workflow_dispatch runs that GitHub does not show on a PR, so the PR read as a wall of cancelled checks (#6250, #6253).

Nothing is cancelled now: the screenshot workflows already skip their jobs while goldens are missing (golden-plan fails naming the gaps), and every other check keeps reporting on the code. The capture sets a pending "Golden capture" commit status on the PR head linking its run; golden-harvest.yml settles it on the captured head and on the commit it pushes (success, or failure when a leg failed or nothing arrived), and marks it an error when the harvest itself fails. The rerun-what-was-cancelled paths are removed.

Takes effect for the harvest from master only (workflow_run runs the default branch's copy); golden-capture.yml runs from the PR's copy.

🤖 Generated with Claude Code

shai-almog and others added 5 commits November 17, 2026 05:44
…it status

A capture cancelled every run of the PR, unit tests and CodeQL included, for
the hours its legs took, and its own runs (workflow_dispatch) do not show on
a PR, so the PR read as a wall of cancelled checks. The screenshot workflows
already skip themselves while goldens are missing; nothing is cancelled now.
The capture sets a pending "Golden capture" status on the head, and the
harvest settles it with the commit, or as a failure.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… any failure; prefer the capture's own runs

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
That is the feature: a PR missing a golden spends no runners until its
goldens exist. The runs stay cancelled when a capture fails, too; the
Golden capture status says why on the PR.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…the listing fails

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@shai-almog
shai-almog merged commit 8954693 into master Nov 17, 2026
6 of 12 checks passed
@shai-almog
shai-almog deleted the golden-capture-no-cancel branch November 17, 2026 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant