Repository navigation
Conversation
Adds a Message my Bestie App Intent and App Shortcut. Siri asks what to say, names the Bestie in its confirmation and posts the message in the person's DM with the Bestie, without opening Buzz. A background launch already builds Home, so a small host widget answers the intent over a method channel, reopening the relay session if the app's background grace period had closed it. ADRs 0004 and 0005 record the engine and intent decisions. Signed-off-by: Tom Brow <tomb@squareup.com>
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2bcccf80fc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: Tom Brow <tomb@squareup.com>
When a quick send fails or Buzz can't tell whether it landed, its text is saved as the Bestie DM's composer draft, after any draft already there, and Siri says so. A successful send leaves the draft alone. An open composer now shows a draft saved by another writer instead of overwriting it. Signed-off-by: Tom Brow <tomb@squareup.com>
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cf3c20afdd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
The send and the DM lookup now catch every failure, including a socket that drops just before publishing, and each draft save first checks the confirmed community. An open composer counts a draft another writer saves as a new revision, so a pending ordinary send that fails can't restore over it. Signed-off-by: Tom Brow <tomb@squareup.com>
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: be396a0e80
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
… up in Capture the scope before the Bestie and profile awaits and check it after, so a community switch mid-lookup can't pair one community's Bestie with another's scope. Signed-off-by: Tom Brow <tomb@squareup.com>
|
@codex review |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🔐 Codex Security Review
Review SummaryOverall Risk: NONE
FindingsNo concrete security, correctness, or reliability findings were identified. Notes
Generated by Codex Security Review | |
Adds a Message my Bestie action for Siri and Shortcuts. Siri asks what to say, confirms with the Bestie's name ("Send “…” to Astra?"), and posts the message in your DM with the Bestie, without opening Buzz. The Bestie's reply arrives as a normal notification, in the same DM the Home star opens.
This is the iOS 16+ App Shortcut from ADR 0005. Follow-ups, not in this PR: the iOS 27
messages.sendMessageschema intent, naming other recipients, a separate "Start a chat with my Bestie" intent for a new Solo chat, and opening Buzz with a draft when a send fails.How it works
QuickSendHost, which the app hands Home as an invisible background widget, takes the send. Nothing is reimplemented natively.SendMessagethe composer uses.Regressions
cachedBestieConversationunchanged, so the star behaves as before.Before / after
The DM result and a demo video show internal names, so they're shared internally rather than here.
Testing
quick_send_test.dartjourney: Home reports ready; Siri's Bestie lookup is refused with no Bestie, then returns the chosen Bestie's pubkey and name; a send confirmed for another community is refused; an empty send is refused without publishing; a send while Buzz is backgrounded and its socket closed reconnects, opens the DM with the Bestie, survives a rate-limited first try, posts the message in that DM tagged to the Bestie, and hands the session back to its background pause; a second send goes to the same DM and leaves the person's draft there as it was; a send whose answer is lost is reported as unsure and kept in that draft after the person's own text, with its mentions; a socket that drops just before the message goes out keeps it too; leaving Home reports unready. Removing the rate-limit retry, the community check or the draft save fails it.just mobile-check mobile-testpasses.buzz-review-completed