Repository navigation
Conversation
🔐 Codex Security Review
|
Signed-off-by: iyuzhang <i.yuzhang@foxmail.com>
fc06651 to
237f0de
Compare
joahg
left a comment
There was a problem hiding this comment.
🤖 This looks right. All four social reads now go through normalize_events + format_events, matching how feed and users handle --format and BUZZ_OUTPUT_FORMAT. OutputFormat still defaults to Json, and the normalized shape keeps id/pubkey/kind/content/created_at/tags/sig, so default output is unchanged for scripts that parse it. The subprocess test runs every read in every format, plus the env fallback, against a local /query fixture, and its agent-format case checks that sig is dropped and the auth tag trimmed.
P3, not blocking: if the response isn't a JSON array, unwrap_or_default() now prints [] where the raw body used to print. That's the same trade-off feed already makes, so fine to leave.
Approving.
|
Thanks for the review. The security check still needs authorization for the current head. Could someone with write access authorize it? |
Summary
Make
social event,notes,contacts, andlistuse the shared event formatter. Agent output drops signature material and trims auth tags; compact output keeps the three-field shape.Related issue
Fixes #9350. No duplicate social-format PR found.
Testing
cargo test -p buzz-cli --locked -- --test-threads=1: 691 passed, 1 doctest ignored.BUZZ_OUTPUT_FORMAT. Forcing the dispatch back to JSON makes it fail.just cistopped at desktop Tauri Clippy because this Linux environment lacksgdk-3.0.pc; the remaining CI stages were not run.The author independently ran
cargo +1.98.1 test -p buzz-cli --test social_outputand confirmed it passed. Agent review and CLI execution against the local HTTP fixture are complete; a live relay was not tested. DCO passes on 237f0de.buzz-review-completed