Skip to content

mobile: tap the settings version footer to copy it - #9021

Merged
brow merged 3 commits into
mainfrom
mobile-copy-version
Nov 4, 2026
Merged

brow merged 3 commits into
mainfrom
mobile-copy-version

Conversation

@brow

@brow brow commented Nov 3, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

The version line at the bottom of mobile Settings (for example v0.27.0 (36)) couldn't be copied, which made it awkward to paste into bug reports. Tapping it now copies the whole string and shows a "Version copied" toast, matching the existing "Copy public key" row. It's keyboard-focusable and has a 48dp tap target. Partial selection isn't supported; it's whole-string only.

Settings after tapping the version: a Version copied toast

Related issue

N/A

Validation

  • Added test: tapping the footer, or reaching it with Tab and pressing Enter, puts v0.16.0 (432) on the clipboard and shows the toast. The test also checks that the tap target is at least 48dp tall.
  • just mobile-check and just mobile-test pass.
  • Automated simulator run (debug build, iOS 27): opened Settings, tapped the version, confirmed via simctl pbpaste that the clipboard held the exact footer text and the toast appeared; then confirmed the neighboring "Copy public key" row still copies the npub and Settings still closes. Human testing waived per the mobile testing exception. A full recording was posted in Buzz instead of here because it shows internal channel names.

🤖 Generated with Claude Code

buzz-review-completed

Tapping the version line at the bottom of Settings copies the whole
string (for example "v0.27.0 (36)") and shows a "Version copied" toast.

Co-authored-by: studio <dc2fc481343672df31a689840c09299972e704dac592e0da6f18486646a7ee3e@buzz.block.builderlab.xyz>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Tom Brow <tomb@squareup.com>
@brow

brow commented Nov 3, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-04T02:39:39.396208Z 4355d50 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. More of your lovely PRs please.

Reviewed commit: bd1baade3a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

child: Semantics(
button: true,
onTapHint: 'Copy version',
child: GestureDetector(

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 P2 · Version copying is unavailable through keyboard navigation

The new footer uses GestureDetector, which supplies neither a focus-traversal stop nor Enter/Space handling. Semantics(button: true) adds the accessibility role, but no keyboard activation. A hardware-keyboard user can traverse the other Settings actions (which use focusable controls) and still cannot reach or activate this copy action. This conflicts with the input-modality contract in AGENTS.md, rule 8.

User/system effect: copying the displayed version is unavailable when navigating Settings by keyboard.

Test: traverse Settings with Tab, then activate the version action with Enter/Space and verify that the complete displayed string reaches the clipboard.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Addressed in 2ea4ad9 by switching the footer to InkWell, so it's a Tab stop and Enter/Space copies it. The test now covers keyboard activation, and it fails on the old GestureDetector.

Use InkWell instead of GestureDetector so the footer is a focus stop and
Enter/Space copies the version, and cover keyboard activation in the test.

Co-authored-by: studio <dc2fc481343672df31a689840c09299972e704dac592e0da6f18486646a7ee3e@buzz.block.builderlab.xyz>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Tom Brow <tomb@squareup.com>
@brow

brow commented Nov 3, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2ea4ad9413

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Constrain the footer's InkWell to kMinInteractiveDimension. The text
keeps its position and the extra height goes below it.

Co-authored-by: studio <dc2fc481343672df31a689840c09299972e704dac592e0da6f18486646a7ee3e@buzz.block.builderlab.xyz>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Tom Brow <tomb@squareup.com>

@johnmatthewtennant johnmatthewtennant left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Reviewed exact head 2ea4ad9413856d7ac034be607414384a0e3155eb with the complete teammate-review workflow. The keyboard-access defect is fixed. No correctness blockers found.

@brow

brow commented Nov 3, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. More of your lovely PRs please.

Reviewed commit: 4355d50af2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@johnmatthewtennant johnmatthewtennant left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Reviewed exact head 4355d50af2aa99a78ed3f38befccc96cdd7281c5 with the complete teammate-review workflow. The 48dp tap-target change preserves keyboard access and whole-version copying. No correctness blockers found.

@brow
brow marked this pull request as ready for review November 4, 2026 02:36
@brow
brow requested a review from a team as a code owner November 4, 2026 02:36
@github-actions github-actions Bot added the codex-security-review-current The posted Codex security review matches its recorded range. label Nov 4, 2026
@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown

🔐 Codex Security Review

Note: This is an automated, security-focused review generated by Codex.
Use it as a supplement to human review; false positives are possible.

Scope

  • Exact PR diff: 3d26ed7dfdd237f99bb65b623070d546384c2538...4355d50af2aa99a78ed3f38befccc96cdd7281c5
  • Model: gpt-6.1-sol

💡 Click "edited" above to see earlier reviews for this PR.


Review Summary

Overall Risk: NONE

Reviewed the version-copy interaction, clipboard helper, feedback path, and added tests. No concrete security, correctness, or reliability findings in the authorized PR range.

Findings

No concrete security, correctness, or reliability findings were identified.

Notes

  • Review used read-only source inspection. Builds and tests were not executed, as instructed.

Generated by Codex Security Review |
Requested by: @brow |
Workflow run

@brow
brow merged commit 38a5d9a into main Nov 4, 2026
60 checks passed
@brow
brow deleted the mobile-copy-version branch November 4, 2026 02:39

This branch was previously deployed

1 inactive deployment
codex-review — 4355d50a Deployed Nov 4, 2026 by brow via Run Codex Security Review #12408
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

codex-security-review-current The posted Codex security review matches its recorded range.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants