Repository navigation
mobile: tap the settings version footer to copy it - #9021
Conversation
Tapping the version line at the bottom of Settings copies the whole string (for example "v0.27.0 (36)") and shows a "Version copied" toast. Co-authored-by: studio <dc2fc481343672df31a689840c09299972e704dac592e0da6f18486646a7ee3e@buzz.block.builderlab.xyz> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Tom Brow <tomb@squareup.com>
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
| child: Semantics( | ||
| button: true, | ||
| onTapHint: 'Copy version', | ||
| child: GestureDetector( |
There was a problem hiding this comment.
🤖 P2 · Version copying is unavailable through keyboard navigation
The new footer uses GestureDetector, which supplies neither a focus-traversal stop nor Enter/Space handling. Semantics(button: true) adds the accessibility role, but no keyboard activation. A hardware-keyboard user can traverse the other Settings actions (which use focusable controls) and still cannot reach or activate this copy action. This conflicts with the input-modality contract in AGENTS.md, rule 8.
User/system effect: copying the displayed version is unavailable when navigating Settings by keyboard.
Test: traverse Settings with Tab, then activate the version action with Enter/Space and verify that the complete displayed string reaches the clipboard.
There was a problem hiding this comment.
🤖 Addressed in 2ea4ad9 by switching the footer to InkWell, so it's a Tab stop and Enter/Space copies it. The test now covers keyboard activation, and it fails on the old GestureDetector.
Use InkWell instead of GestureDetector so the footer is a focus stop and Enter/Space copies the version, and cover keyboard activation in the test. Co-authored-by: studio <dc2fc481343672df31a689840c09299972e704dac592e0da6f18486646a7ee3e@buzz.block.builderlab.xyz> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Tom Brow <tomb@squareup.com>
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2ea4ad9413
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Constrain the footer's InkWell to kMinInteractiveDimension. The text keeps its position and the extra height goes below it. Co-authored-by: studio <dc2fc481343672df31a689840c09299972e704dac592e0da6f18486646a7ee3e@buzz.block.builderlab.xyz> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Tom Brow <tomb@squareup.com>
johnmatthewtennant
left a comment
There was a problem hiding this comment.
🤖 Reviewed exact head 2ea4ad9413856d7ac034be607414384a0e3155eb with the complete teammate-review workflow. The keyboard-access defect is fixed. No correctness blockers found.
|
@codex review |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
johnmatthewtennant
left a comment
There was a problem hiding this comment.
🤖 Reviewed exact head 4355d50af2aa99a78ed3f38befccc96cdd7281c5 with the complete teammate-review workflow. The 48dp tap-target change preserves keyboard access and whole-version copying. No correctness blockers found.
🔐 Codex Security Review
Review SummaryOverall Risk: NONE
FindingsNo concrete security, correctness, or reliability findings were identified. Notes
Generated by Codex Security Review | |
Summary
The version line at the bottom of mobile Settings (for example
v0.27.0 (36)) couldn't be copied, which made it awkward to paste into bug reports. Tapping it now copies the whole string and shows a "Version copied" toast, matching the existing "Copy public key" row. It's keyboard-focusable and has a 48dp tap target. Partial selection isn't supported; it's whole-string only.Related issue
N/A
Validation
v0.16.0 (432)on the clipboard and shows the toast. The test also checks that the tap target is at least 48dp tall.just mobile-checkandjust mobile-testpass.simctl pbpastethat the clipboard held the exact footer text and the toast appeared; then confirmed the neighboring "Copy public key" row still copies the npub and Settings still closes. Human testing waived per the mobile testing exception. A full recording was posted in Buzz instead of here because it shows internal channel names.🤖 Generated with Claude Code
buzz-review-completed