Repository navigation
fix(mobile): replay native navigation state when returning Home - #8314
Conversation
Signed-off-by: kenny lopez <klopez4212@gmail.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
🔐 Codex Security Review
Review SummaryOverall Risk: NONE
FindingsNo concrete security, correctness, or reliability findings were identified. Notes
Generated by Codex Security Review | |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c92cdc43bc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
wesbillman
left a comment
There was a problem hiding this comment.
🤖 Carl, an automated reviewer, commenting via Wes's GitHub account.
Requesting changes: the fix and its regression test cover a restore path that production Home does not currently take, so this PR doesn't yet show that it fixes the bug users see. Details are in the inline thread below. Mobile CI is green at c92cdc43.
To merge: name the production path that loses the frost, and make the regression test go through that path with no harness-only PageStorageKey. If restoring Home's offset after recreation is intended behavior, add that storage identity in production code and test it through HomePage.
Signed-off-by: kenny lopez <klopez4212@gmail.com>
wesbillman
left a comment
There was a problem hiding this comment.
🤖 Carl, an automated reviewer, commenting via Wes's GitHub account.
Requesting changes. Last round's issue is fixed: the test now uses the real HomePage with no storage key. But the new trigger only runs for some of the routes that cover Home, and Settings is one it misses. Details are in the inline thread. Mobile CI is green at 7e2cf1c1.
To merge:
- The reveal fires when Home comes back from every covering route, Settings included, with a regression test for a
PageRouteBuilderroute. - On-device check that the frost really comes back. The PR body says this is still pending.
Signed-off-by: kenny lopez <klopez4212@gmail.com>
wesbillman
left a comment
There was a problem hiding this comment.
🤖 Carl, an automated reviewer, commenting via Wes's GitHub account.
No code blockers at 75ed0503. The custom-route gap is fixed. RouteAware.didPopNext runs no matter which route type covered Home. The observer move keeps voiceNoteRouteObserver as an alias for the same instance, so voice-note cancellation still works. The isCurrent guards also stop a replay if another route gets pushed within the same frame. The new custom=true test covers the Settings-style PageRouteBuilder path.
Before merge:
- Mobile CI is still pending.
- Someone still has to check on a device that the frost comes back. If it doesn't, check timing first. The post-frame
prepareForRevealcan reach UIKit before the platform view is back in a window. In that caseapplyScroll'swindowguard turns it into a no-op.
Restore the iOS navigation bar after any covering route pops, including opaque custom Settings and community routes. Use the shared app RouteObserver and didPopNext, then replay scroll depth and request native layout after Flutter paints the uncovered view. Voice recording retains the same observer through its existing alias.
Regression coverage uses the real HomePage with both MaterialPageRoute and opaque PageRouteBuilder, at scrolled and top-of-list positions. The custom-route case fails before this change.
Validation: 107 focused tests and analysis passed. Full mobile runs stalled under local disk pressure, so full-suite validation is incomplete. On-device verification of this follow-up remains pending.