Skip to content

fix(mobile): replay native navigation state when returning Home - #8314

Merged
klopez4212 merged 3 commits into
mainfrom
kennylopez-home-blur-latest
Oct 14, 2026
Merged

klopez4212 merged 3 commits into
mainfrom
kennylopez-home-blur-latest

Conversation

@klopez4212

@klopez4212 klopez4212 commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Restore the iOS navigation bar after any covering route pops, including opaque custom Settings and community routes. Use the shared app RouteObserver and didPopNext, then replay scroll depth and request native layout after Flutter paints the uncovered view. Voice recording retains the same observer through its existing alias.

Regression coverage uses the real HomePage with both MaterialPageRoute and opaque PageRouteBuilder, at scrolled and top-of-list positions. The custom-route case fails before this change.

Validation: 107 focused tests and analysis passed. Full mobile runs stalled under local disk pressure, so full-suite validation is incomplete. On-device verification of this follow-up remains pending.

Signed-off-by: kenny lopez <klopez4212@gmail.com>
@klopez4212
klopez4212 requested a review from a team as a code owner October 14, 2026 12:24
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-14T20:18:51.951682Z 75ed050 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions github-actions Bot added the codex-security-review-current The posted Codex security review matches its recorded range. label Oct 14, 2026
@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

🔐 Codex Security Review

Note: This is an automated, security-focused review generated by Codex.
Use it as a supplement to human review; false positives are possible.

Scope

  • Exact PR diff: 7b9551aba830019a875b6fc24b5a25d74eceeb65...75ed0503426e435dde6f0a687147cc242ba0484b
  • Model: gpt-6.1-sol

💡 Click "edited" above to see earlier reviews for this PR.


Review Summary

Overall Risk: NONE

No concrete issues found in the authorized PR range after tracing navigation restoration, native method handling, and voice-note lifecycle cleanup.

Findings

No concrete security, correctness, or reliability findings were identified.

Notes

  • Review used read-only source inspection. Builds and tests were not run, as requested.

Generated by Codex Security Review |
Requested by: @klopez4212 |
Workflow run

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c92cdc43bc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@wesbillman wesbillman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Carl, an automated reviewer, commenting via Wes's GitHub account.

Requesting changes: the fix and its regression test cover a restore path that production Home does not currently take, so this PR doesn't yet show that it fixes the bug users see. Details are in the inline thread below. Mobile CI is green at c92cdc43.

To merge: name the production path that loses the frost, and make the regression test go through that path with no harness-only PageStorageKey. If restoring Home's offset after recreation is intended behavior, add that storage identity in production code and test it through HomePage.

Signed-off-by: kenny lopez <klopez4212@gmail.com>
@github-actions github-actions Bot removed the codex-security-review-current The posted Codex security review matches its recorded range. label Oct 14, 2026
@klopez4212 klopez4212 changed the title fix(mobile): restore Home header frost after scroll restoration fix(mobile): replay native navigation state when returning Home Oct 14, 2026
@github-actions github-actions Bot added the codex-security-review-current The posted Codex security review matches its recorded range. label Oct 14, 2026

@wesbillman wesbillman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Carl, an automated reviewer, commenting via Wes's GitHub account.

Requesting changes. Last round's issue is fixed: the test now uses the real HomePage with no storage key. But the new trigger only runs for some of the routes that cover Home, and Settings is one it misses. Details are in the inline thread. Mobile CI is green at 7e2cf1c1.

To merge:

  • The reveal fires when Home comes back from every covering route, Settings included, with a regression test for a PageRouteBuilder route.
  • On-device check that the frost really comes back. The PR body says this is still pending.

Signed-off-by: kenny lopez <klopez4212@gmail.com>
@github-actions github-actions Bot removed the codex-security-review-current The posted Codex security review matches its recorded range. label Oct 14, 2026
@github-actions github-actions Bot added the codex-security-review-current The posted Codex security review matches its recorded range. label Oct 14, 2026

@wesbillman wesbillman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Carl, an automated reviewer, commenting via Wes's GitHub account.

No code blockers at 75ed0503. The custom-route gap is fixed. RouteAware.didPopNext runs no matter which route type covered Home. The observer move keeps voiceNoteRouteObserver as an alias for the same instance, so voice-note cancellation still works. The isCurrent guards also stop a replay if another route gets pushed within the same frame. The new custom=true test covers the Settings-style PageRouteBuilder path.

Before merge:

  • Mobile CI is still pending.
  • Someone still has to check on a device that the frost comes back. If it doesn't, check timing first. The post-frame prepareForReveal can reach UIKit before the platform view is back in a window. In that case applyScroll's window guard turns it into a no-op.

@klopez4212
klopez4212 merged commit a83ea69 into main Oct 14, 2026
42 checks passed
@klopez4212
klopez4212 deleted the kennylopez-home-blur-latest branch October 14, 2026 20:38

This branch was previously deployed

1 inactive deployment
codex-review — 75ed0503 Deployed Oct 14, 2026 by klopez4212 via Run Codex Security Review #8095
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

codex-security-review-current The posted Codex security review matches its recorded range.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants