Repository navigation
Conversation
hvadehra
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #390.
The BUILD file generated for remote JDK repositories exposes
bin,conf,include,libandjmodsthrough filegroups, but the downloadedlegal/directory is not reachable from any target. Projects that redistribute the JDK, for example by packaging it into a container image, need those notices: OpenJDK bundles third-party components whose licenses require them to accompany copies.This adds a
jdk-legalfilegroup overlegal/**, following the naming andallow_emptyconvention of the existingjdk-*filegroups. It is not added to thejava_runtimesrcs, so runtime runfiles are unchanged.