Repository navigation
fix: keep original error as inner on secret callback failure - #1057
Open
webdevelopersrinu wants to merge 1 commit into
Open
webdevelopersrinu wants to merge 1 commit into
webdevelopersrinu wants to merge 1 commit into
Conversation
Fixes auth0#746. The error from the secretOrPublicKey callback was only kept as text in the message, so callers could not check what actually failed. Now it is also set as err.inner.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #746
When the secretOrPublicKey callback fails, the original error was only
kept as text inside the message. So the only way to know what failed was
parsing the message string. I changed verify to also set the original
error as err.inner, same as other errors in this library already do.
Updated the two existing tests to check err.inner. All tests pass.