Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

return service also in "findCredentials" #144

Open

Description

@TqrHsn

"findCredentials" method performs a wildcard search on all service entries. So, with the result array {account, password} it is impossible to determine which service is it referring to. It would be better if it returns array {service, account, password}.

More details:
My app supports adding multiple credentials with a prefix like "my-app:service1", "my-app:service2" and so on. So when I call findCredentials("my-app"), it returns all the entries for my-app but I am unable to determine which result entry is referring to which service. This can be solved if method returns {service, account, password} instead of just {account, password}.

Activity

  1. shiftkey commented on Jan 21, 2019

    @shiftkey
    Contributor

    Marking this as help-wanted because I think this is some low-hanging fruit for someone to contribute:

    This can be solved if method returns {service, account, password} instead of just {account, password}.

  2. MRayermannMSFT commented on Dec 5, 2019

    @MRayermannMSFT

    It looks like windows is the only platform that performs a wildcard search. So @shiftkey , for mac and linux, all results should have the same service, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions