Repository navigation
HTTPCLIENT-2438: AsyncIoByteCounterExec: create counter builders per request - #932
Open
shinseongsu wants to merge 1 commit into
Open
shinseongsu wants to merge 1 commit into
shinseongsu wants to merge 1 commit into
Conversation
…request The builders were shared fields and Counter.Builder#tags adds to the existing tags, so a tag set for one request stayed on the builder and was applied to the counters of all later requests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/HTTPCLIENT-2438
AsyncIoByteCounterExec kept the two Counter.Builder instances in fields and called tags() on them for every request. tags() adds to what the builder already has, so a tag that only some requests get (e.g. from a tagCustomizer) stayed on the builder and showed up on the counters of every request after it.
The builders are now created in record() for each request, same as IoByteCounterExec does on the classic side.
With a tagCustomizer that adds
only_for_a=yesfor /a only, sending GET /a (200) and then GET /b (404):Before:
After:
Added this as a test in AsyncIoByteCounterExecTest. It fails on master and passes with the change.
./mvnw -pl httpclient5-observation -am verifypasses.This touches the same class as #920 but a different part, so it should merge cleanly either way. Could this go to 5.6.x as well?