Skip to content

HIVE-30255: Correct iceberg jars in distribution are handler (uber jar) and catalog, rest-client thin API jars - #6958

Open
chinnaraolalam wants to merge 1 commit into
apache:masterfrom
chinnaraolalam:icberg_jars
Open

chinnaraolalam wants to merge 1 commit into
apache:masterfrom
chinnaraolalam:icberg_jars

Conversation

@chinnaraolalam

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

present distribution contains these iceberg libs

hive-iceberg-catalog-4.3.0-SNAPSHOT.jar
hive-iceberg-handler-4.3.0-SNAPSHOT.jar
hive-iceberg-shading-4.3.0-SNAPSHOT.jar

Here iceberg-shading files will present in iceberg-handler as it is uber jar so no need of this jar.
Good to have thin API jars (catalog,rest-client)

Expected jars in distribution are

hive-iceberg-catalog-4.3.0-SNAPSHOT.jar
hive-iceberg-handler-4.3.0-SNAPSHOT.jar
hive-iceberg-rest-catalog-client-4.3.0-SNAPSHOT.jar

Why are the changes needed?

Due to jars like shading or patched jar present in distribution without shadding we are seeing classpath issues.

Caused by: java.lang.NoSuchMethodError: 'org.apache.avro.LogicalTypes$TimestampNanos org.apache.avro.LogicalTypes.timestampNanos()' at org.apache.iceberg.avro.TypeToSchema.<clinit>(TypeToSchema.java:50)
Need to unify these jars.

Does this PR introduce any user-facing change?

Discarded few unneccesary jars from distribution

How was this patch tested?

Existing UT's

…r) and catalog, rest-client thin API jars to avoid class path issues
@sonarqubecloud

Copy link
Copy Markdown

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants