Skip to content

[chore](audit) let line comment work well - #40599

Merged
morrySnow merged 1 commit into
apache:masterfrom
morrySnow:audit_log
Sep 11, 2024
Merged

[chore](audit) let line comment work well#40599
morrySnow merged 1 commit into
apache:masterfrom
morrySnow:audit_log

Conversation

@morrySnow

@morrySnow morrySnow commented Sep 10, 2024

Copy link
Copy Markdown
Contributor

should replace new line character with '\n', not ' '

intro by #37894

@morrySnow
[chore](audit) let line comment work well
c22e0ee 
should replace new line character with '\n', not ' '

intro by apache#37894
@doris-robot

doris-robot commented Sep 10, 2024

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@morrySnow

morrySnow commented Sep 10, 2024

Copy link
Copy Markdown
Contributor Author

run buildall

@doris-robot

doris-robot commented Sep 10, 2024

Copy link
Copy Markdown
TPC-H: Total hot run time: 38362 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit c22e0ee2a9f535b1dc1bcd2f394f384bff382e32, data reload: false

------ Round 1 ----------------------------------
q1	17651	4728	4330	4330
q2	2038	195	195	195
q3	10948	961	1144	961
q4	10518	776	770	770
q5	7756	2874	2861	2861
q6	229	142	138	138
q7	976	631	600	600
q8	9325	2101	2116	2101
q9	6962	6606	6592	6592
q10	7043	2231	2219	2219
q11	490	248	261	248
q12	406	223	226	223
q13	18748	3150	3112	3112
q14	286	242	241	241
q15	543	514	478	478
q16	561	439	432	432
q17	993	709	697	697
q18	7641	6945	7011	6945
q19	1384	1067	1043	1043
q20	671	332	337	332
q21	3972	2996	2845	2845
q22	1125	1002	999	999
Total cold run time: 110266 ms
Total hot run time: 38362 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4422	4311	4345	4311
q2	380	269	269	269
q3	2903	2655	2605	2605
q4	1964	1651	1705	1651
q5	5741	5735	5829	5735
q6	237	135	135	135
q7	2209	1814	1814	1814
q8	3343	3465	3527	3465
q9	8888	8863	8842	8842
q10	3662	3404	3378	3378
q11	620	527	527	527
q12	858	680	662	662
q13	13567	3237	3369	3237
q14	327	281	283	281
q15	533	492	490	490
q16	559	529	491	491
q17	1866	1561	1519	1519
q18	8210	8014	8044	8014
q19	1737	1688	1548	1548
q20	2216	1916	1937	1916
q21	5836	5452	5458	5452
q22	1121	1042	1010	1010
Total cold run time: 71199 ms
Total hot run time: 57352 ms

@doris-robot

doris-robot commented Sep 10, 2024

Copy link
Copy Markdown
TPC-DS: Total hot run time: 198131 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit c22e0ee2a9f535b1dc1bcd2f394f384bff382e32, data reload: false

query1	1284	883	891	883
query2	6352	2053	1953	1953
query3	10612	4112	3880	3880
query4	60063	27414	23242	23242
query5	5042	509	492	492
query6	395	179	174	174
query7	5595	299	292	292
query8	324	236	232	232
query9	7914	2616	2599	2599
query10	427	296	306	296
query11	16697	15113	15405	15113
query12	157	111	108	108
query13	1447	411	401	401
query14	10609	7060	7063	7060
query15	217	179	186	179
query16	6760	475	452	452
query17	1079	567	574	567
query18	1558	309	297	297
query19	219	155	161	155
query20	121	110	135	110
query21	224	109	107	107
query22	4755	4391	4529	4391
query23	34400	33405	33649	33405
query24	6037	2908	2896	2896
query25	493	387	406	387
query26	596	157	151	151
query27	1592	274	277	274
query28	3812	2078	2056	2056
query29	640	410	409	409
query30	234	157	160	157
query31	942	761	780	761
query32	73	54	54	54
query33	463	291	293	291
query34	894	480	500	480
query35	843	712	705	705
query36	1043	915	980	915
query37	148	92	91	91
query38	3937	3932	4030	3932
query39	1450	1442	1378	1378
query40	243	120	120	120
query41	47	48	45	45
query42	114	96	95	95
query43	492	492	474	474
query44	1104	753	752	752
query45	195	165	166	165
query46	1101	758	742	742
query47	1925	1795	1852	1795
query48	374	291	293	291
query49	777	440	444	440
query50	842	432	419	419
query51	6966	7052	6821	6821
query52	99	91	89	89
query53	253	178	181	178
query54	573	463	447	447
query55	76	75	78	75
query56	269	250	264	250
query57	1218	1076	1108	1076
query58	240	265	235	235
query59	3071	2981	2961	2961
query60	309	275	278	275
query61	112	101	105	101
query62	745	652	666	652
query63	223	184	184	184
query64	1384	695	672	672
query65	3250	3183	3167	3167
query66	660	338	360	338
query67	15935	15480	15521	15480
query68	1692	869	892	869
query69	426	340	335	335
query70	1193	1186	1189	1186
query71	351	340	340	340
query72	4592	3661	3470	3470
query73	597	583	579	579
query74	9051	8850	9013	8850
query75	3087	2972	2976	2972
query76	1053	850	835	835
query77	520	414	411	411
query78	10082	9262	9174	9174
query79	914	887	866	866
query80	819	800	825	800
query81	450	256	260	256
query82	273	267	273	267
query83	192	192	189	189
query84	212	110	109	109
query85	631	457	504	457
query86	320	317	325	317
query87	4319	4308	4347	4308
query88	4280	4177	4184	4177
query89	389	369	371	369
query90	1107	319	315	315
query91	127	124	126	124
query92	78	77	75	75
query93	914	913	907	907
query94	402	357	356	356
query95	432	423	422	422
query96	484	480	480	480
query97	3148	3153	3141	3141
query98	231	252	232	232
query99	1298	1279	1286	1279
Total cold run time: 295709 ms
Total hot run time: 198131 ms

@doris-robot

doris-robot commented Sep 10, 2024

Copy link
Copy Markdown
ClickBench: Total hot run time: 31.85 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit c22e0ee2a9f535b1dc1bcd2f394f384bff382e32, data reload: false

query1	0.05	0.05	0.04
query2	0.08	0.04	0.04
query3	0.22	0.05	0.05
query4	1.66	0.10	0.09
query5	0.51	0.50	0.50
query6	1.14	0.74	0.75
query7	0.02	0.01	0.02
query8	0.06	0.04	0.05
query9	0.55	0.50	0.51
query10	0.54	0.58	0.56
query11	0.16	0.12	0.12
query12	0.15	0.13	0.13
query13	0.61	0.59	0.59
query14	1.40	1.41	1.40
query15	0.85	0.83	0.85
query16	0.37	0.37	0.39
query17	1.07	1.06	1.07
query18	0.23	0.20	0.22
query19	1.98	1.74	1.88
query20	0.01	0.01	0.01
query21	15.39	0.67	0.65
query22	4.07	7.71	2.11
query23	18.27	1.44	1.35
query24	2.10	0.23	0.21
query25	0.14	0.09	0.08
query26	0.26	0.18	0.18
query27	0.07	0.08	0.06
query28	13.28	1.03	1.00
query29	12.64	3.35	3.39
query30	0.24	0.06	0.06
query31	2.86	0.42	0.40
query32	3.24	0.48	0.49
query33	2.98	3.04	2.99
query34	17.02	4.43	4.40
query35	4.44	4.48	4.45
query36	0.66	0.50	0.47
query37	0.19	0.16	0.15
query38	0.14	0.14	0.15
query39	0.04	0.04	0.04
query40	0.16	0.13	0.13
query41	0.10	0.04	0.05
query42	0.06	0.05	0.05
query43	0.05	0.04	0.04
Total cold run time: 110.06 s
Total hot run time: 31.85 s

@github-actions

github-actions Bot commented Sep 11, 2024

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions Bot added the approved Indicates a PR has been approved by one committer. label Sep 11, 2024
@github-actions

github-actions Bot commented Sep 11, 2024

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@morrySnow
morrySnow merged commit aab6204 into apache:master Sep 11, 2024
@morrySnow
morrySnow deleted the audit_log branch September 11, 2024 14:44
dataroaring pushed a commit that referenced this pull request Sep 26, 2024
@morrySnow @dataroaring
[chore](audit) let line comment work well (#40599)
af3850f 
should replace new line character with '\n', not ' '
@yagagagaga yagagagaga mentioned this pull request Oct 21, 2024
Merged
yiguolei pushed a commit that referenced this pull request Oct 22, 2024
@yagagagaga
[cherry-pick][chore](audit) Optimize the SQL (insert into values) len…
104d427 
…gth in audit logs (#37894) and let line comment work well (#40599) (#42186)

## Proposed changes

cherry-pick from master #37894 and #40599

<!--Describe your changes.-->
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
@morrySnow @HappenLee
[chore](audit) let line comment work well (apache#40599)
ed389ac 
should replace new line character with '\n', not ' '
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@starocean999 starocean999 starocean999 approved these changes
+1 more reviewer
@feiniaofeiafei feiniaofeiafei feiniaofeiafei approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.7-merged dev/3.0.2-merged p0_b reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@morrySnow @doris-robot @starocean999 @feiniaofeiafei @wm1581066 @dataroaring