Skip to content

DRAFT Bench 27361 - #27362

Draft
kosiew wants to merge 7 commits into
apache:mainfrom
kosiew:bench-27361
Draft

DRAFT Bench 27361#27362
kosiew wants to merge 7 commits into
apache:mainfrom
kosiew:bench-27361

Conversation

@kosiew

@kosiew kosiew commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

bench 27361

@kosiew
Implement Rust-only policy API with explicit override and legacy bool…
1cf4d8c 
… APIs retained

- Implemented Rust-only policy API with lower/upper/preserve options
- Added explicit override for policy settings
- Ensured consistent discovery, binding, and DDL
- Retained legacy bool APIs
- No session setting included
@kosiew
Fix lateral in datafusion/sql/src/relation/mod.rs: lookup retains leg…
94d4341 
…acy normalization

- Fixed function lookup to retain legacy normalization despite explicit object policy.
- Added regression coverage for policies, quoted names, legacy modes, and ordinary calls.
@kosiew
test: verify UPDATE identifier casing and document Preserve behavior
7b29daf 
- datafusion/sql/tests/sql_integration.rs: exact UPDATE assertions with unquoted uppercase and quoted lowercase cases.
- docs/source/library-user-guide/upgrading/57.0.0.md: explains explicit Preserve vs legacy false.
@kosiew
Fix legacy boolean folding in datafusion/sql/src/expr/identifier.rs: …
f5c3ed0 
…multipart

- Fixed variables retaining legacy boolean folding independent of object policy.
- Ensured consistent behavior across identifier expressions.
@kosiew
Implement strict schema binding and escaping rules
4ec7779 
- Implement strict schema binding with exact expressions and types, including quoted and unquoted values
- Add escaped partition quote for exact key-schema name matching
@kosiew
Rename legacy helpers, enforce policy-aware methods
af68d16 
- statement.rs: renamed private legacy helpers; policy-aware methods unchanged.
- sql_integration.rs: explicit COPY partition expectations.
@kosiew
Refactor SQL Integration Tests: Simplify Struct, Partition, and Varia…
664fe1f 
…ble Logic

- Merged struct declaration/reference checks for clarity.
- Consolidated partition cases and lateral setup into a single pattern.
- Implemented table-driven variable expectations for consistent behavior.
@kosiew

kosiew commented Nov 12, 2026

Copy link
Copy Markdown
Contributor Author

run benchmark sql_planner

   env:
     BENCH_FILTER: "logical_select_one_from_700"

@adriangbot

adriangbot commented Nov 12, 2026

Copy link
Copy Markdown

🤖 Benchmark running (GKE) | trigger
Instance: c4a-highmem-16 (12 vCPU / 65 GiB) | Linux bench-c6820146465-4820-mb8sw 6.12.105+ #1 SMP Sat Sep 19 07:55:25 UTC 2026 aarch64 GNU/Linux

CPU Details (lscpu) 
Architecture:                            aarch64
CPU op-mode(s):                          64-bit
Byte Order:                              Little Endian
CPU(s):                                  16
On-line CPU(s) list:                     0-15
Vendor ID:                               ARM
Model name:                              Neoverse-V2
Model:                                   1
Thread(s) per core:                      1
Core(s) per cluster:                     16
Socket(s):                               -
Cluster(s):                              1
Stepping:                                r0p1
BogoMIPS:                                2000.00
Flags:                                   fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm bf16 dgh rng bti
L1d cache:                               1 MiB (16 instances)
L1i cache:                               1 MiB (16 instances)
L2 cache:                                32 MiB (16 instances)
L3 cache:                                80 MiB (1 instance)
NUMA node(s):                            1
NUMA node0 CPU(s):                       0-15
Vulnerability Gather data sampling:      Not affected
Vulnerability Indirect target selection: Not affected
Vulnerability Itlb multihit:             Not affected
Vulnerability L1tf:                      Not affected
Vulnerability Mds:                       Not affected
Vulnerability Meltdown:                  Not affected
Vulnerability Mmio stale data:           Not affected
Vulnerability Reg file data sampling:    Not affected
Vulnerability Retbleed:                  Not affected
Vulnerability Spec rstack overflow:      Not affected
Vulnerability Spec store bypass:         Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1:                Mitigation; __user pointer sanitization
Vulnerability Spectre v2:                Mitigation; CSV2, BHB
Vulnerability Srbds:                     Not affected
Vulnerability Tsa:                       Not affected
Vulnerability Tsx async abort:           Not affected
Vulnerability Vmscape:                   Not affected

Comparing bench-27361 (664fe1f) to f94aaa1 (merge-base) diff

Run configuration 
run benchmark sql_planner
env:
  BENCH_FILTER: "logical_select_one_from_700"

Results will be posted here when complete

File an issue against this benchmark runner

@github-actions github-actions Bot added documentation Improvements or additions to documentation sql SQL Planner core Core DataFusion crate common Related to common crate labels Nov 12, 2026
@adriangbot

adriangbot commented Nov 12, 2026

Copy link
Copy Markdown

🤖 Benchmark completed (GKE) | trigger

Instance: c4a-highmem-16 (12 vCPU / 65 GiB)

Comparing bench-27361 (664fe1f) to f94aaa1 (merge-base) diff

Run configuration 
run benchmark sql_planner
env:
  BENCH_FILTER: "logical_select_one_from_700"
CPU Details (lscpu) 
Architecture:                            aarch64
CPU op-mode(s):                          64-bit
Byte Order:                              Little Endian
CPU(s):                                  16
On-line CPU(s) list:                     0-15
Vendor ID:                               ARM
Model name:                              Neoverse-V2
Model:                                   1
Thread(s) per core:                      1
Core(s) per cluster:                     16
Socket(s):                               -
Cluster(s):                              1
Stepping:                                r0p1
BogoMIPS:                                2000.00
Flags:                                   fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm bf16 dgh rng bti
L1d cache:                               1 MiB (16 instances)
L1i cache:                               1 MiB (16 instances)
L2 cache:                                32 MiB (16 instances)
L3 cache:                                80 MiB (1 instance)
NUMA node(s):                            1
NUMA node0 CPU(s):                       0-15
Vulnerability Gather data sampling:      Not affected
Vulnerability Indirect target selection: Not affected
Vulnerability Itlb multihit:             Not affected
Vulnerability L1tf:                      Not affected
Vulnerability Mds:                       Not affected
Vulnerability Meltdown:                  Not affected
Vulnerability Mmio stale data:           Not affected
Vulnerability Reg file data sampling:    Not affected
Vulnerability Retbleed:                  Not affected
Vulnerability Spec rstack overflow:      Not affected
Vulnerability Spec store bypass:         Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1:                Mitigation; __user pointer sanitization
Vulnerability Spectre v2:                Mitigation; CSV2, BHB
Vulnerability Srbds:                     Not affected
Vulnerability Tsa:                       Not affected
Vulnerability Tsx async abort:           Not affected
Vulnerability Vmscape:                   Not affected
Details 

group                          HEAD                                   bench-27361
-----                          ----                                   -----------
logical_select_one_from_700    1.00    232.6±1.84µs        ? ?/sec    1.00    232.9±2.13µs        ? ?/sec

Resource Usage

sql_planner — base (merge-base)

Metric Value
Wall time 525.1s
Peak memory 27.2 MiB
Avg memory 546.9 KiB
CPU user 9.5s
CPU sys 0.0s
Peak spill 0 B

sql_planner — branch

Metric Value
Wall time 520.1s
Peak memory 93.0 MiB
Avg memory 683.8 KiB
CPU user 12.5s
CPU sys 0.0s
Peak spill 0 B

File an issue against this benchmark runner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

common Related to common crate core Core DataFusion crate documentation Improvements or additions to documentation sql SQL Planner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kosiew @adriangbot