Repository navigation
Conversation
…ng aggregate Add AggregateUnionNullBranchRule as CoreRules.AGGREGATE_UNION_NULL_BRANCH. A UNION ALL branch is irrelevant to an enclosing aggregate when every aggregate call ignores NULLs, for example, SUM, SUM0, MIN, MAX, AVG, COUNT(col), and reads a column that the branch produces as constant NULL. Without GROUP BY the branch is removed, but at least one branch is kept. With GROUP BY the branch is kept because it contributes group keys, but a redundant pure GROUP BY inside it is removed. COUNT(*), other aggregates, and UNION distinct are not affected.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Add AggregateUnionNullBranchRule as CoreRules.AGGREGATE_UNION_NULL_BRANCH. A UNION ALL branch is irrelevant to an enclosing aggregate when every aggregate call ignores NULLs, for example, SUM, SUM0, MIN, MAX, AVG, COUNT(col), and reads a column that the branch produces as constant NULL.
Without GROUP BY the branch is removed, but at least one branch is kept. With GROUP BY the branch is kept because it contributes group keys, but a redundant pure GROUP BY inside it is removed.
COUNT(*), other aggregates, and UNION distinct are not affected.
Jira Link
CALCITE-7912