Repository navigation
fix: initialize session mode from resolved Codex permissions - #739
Open
PedroScholemberg wants to merge 2 commits into
Open
PedroScholemberg wants to merge 2 commits into
PedroScholemberg wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related to #702. Initialize a session mode using the sandbox, approval policy, and reviewer resolved by Codex when no explicit initial mode or active named permission profile takes precedence. Preserve non-preset policy combinations in a configured mode.
When an unprompted session is reloaded while its adapter session is still available, retain its selected mode, including a mode chosen by the client.
Limitation
If the adapter no longer has the session in memory, the fallback for an unmaterialized thread uses
thread/read, which does not report permissions. The original mode cannot be recovered from that response; this PR does not cover that case.Testing
npm run typecheckandnpm run buildpassed.end_turn; this did not verify each policy combination.npm teston Windows: 2,368 passed, 88 failed, 47 skipped. One investigated failure expects Unix path separators and receives Windows separators; the causes of the other failures have not all been established. The full suite has not passed.