Repository navigation
Conversation
PR #7220 updated Tag and WasmBinaryWriter to store and emit HeapTypes instead of Signatures so tag types retain rec group, supertype, and finality information, but WasmBinaryReader::readTagImport and WasmBinaryReader::readTags still called getSignatureByTypeIndex, which reconstructed a fresh canonical HeapType from the Signature. Replace getSignatureByTypeIndex with getSignatureTypeByIndex, which validates that the referenced type is a signature while returning the original HeapType, and call .getSignature() at the caller that still needs a Signature. Fixes #9365.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the WASM binary reader by replacing the getSignatureByTypeIndex method with getSignatureTypeByIndex, which returns a HeapType instead of a Signature. This change allows tags to support sub and super heap types, and the test suite in tags.wast has been updated to verify this behavior. There are no review comments, so I have no feedback to provide.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #7220 updated Tag and WasmBinaryWriter to store and emit HeapTypes instead of Signatures so tag types retain rec group, supertype, and finality information, but WasmBinaryReader::readTagImport and WasmBinaryReader::readTags still called getSignatureByTypeIndex, which reconstructed a fresh canonical HeapType from the Signature. Replace getSignatureByTypeIndex with getSignatureTypeByIndex, which validates that the referenced type is a signature while returning the original HeapType, and call .getSignature() at the caller that still needs a Signature.
Fixes #9365.