Repository navigation
Migrate three legacy pass tests to lit - #9367
Open
Eduardo-Gv17 wants to merge 1 commit into
Open
Eduardo-Gv17 wants to merge 1 commit into
Eduardo-Gv17 wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces new LIT-style tests for several WebAssembly optimization passes in wasm-opt, specifically targeting duplicate import elimination, the interaction between unused name removal and precomputation, and setting globals via pass arguments. These tests replace older, separate test files to streamline the test suite. I have no feedback to provide as there are no review comments and the changes consist of clean test additions.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate three legacy pass tests to lit:
Each test now includes its RUN command and FileCheck expectations.
Remove the corresponding legacy input/output files and preserve the
set-globals pass arguments (foo=1337,bar=42).
No optimization pass implementations are changed!
Validation:
Related to #8520.