Repository navigation
Conversation
When `MemoryPacking::createSplitSegments` splits a data segment into multiple non-zero ranges, ranges after the first were previously named `<name>.<N>` without checking whether a segment with that name already existed in the module (for example from an earlier run of `--memory-packing` or in the input module). This caused duplicate segment names in `packed` and triggered an assertion failure in `Module::updateDataSegmentsMap()`. Increment the suffix counter until a name not already present in the module is found.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the MemoryPacking pass to prevent name collisions when splitting data segments. It modifies the createSplitSegments function to accept a Module pointer instead of a Builder reference, allowing it to use Names::getValidDataSegmentName to ensure unique segment names. A corresponding test case has been added to verify this behavior. I have no feedback to provide as there are no review comments.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
MemoryPacking::createSplitSegmentssplits a data segment into multiple non-zero ranges, ranges after the first were previously named<name>.<N>without checking whether a segment with that name already existed in the module (for example from an earlier run of--memory-packingor in the input module). This caused duplicate segment names inpackedand triggered an assertion failure inModule::updateDataSegmentsMap(). Increment the suffix counter until a name not already present in the module is found.