Skip to content

[Feature Request]: Allow merging of multiple config files #704

Description

@jakubledl

Is your feature request related to a problem? Please describe.

In many projects, including now our own, one sees two or three different YAML configurations for UI5, each doing a different thing (one running with the mockserver middleware, a different one with the fiori local middleware &c.), but all sharing a lot of common information.

Describe the solution you'd like

Suppose I have e.g. ui5.yaml:

specVersion: "2.0"
metadata:
  name: ...
type: application
...

and mockserver.yaml:

server:
  customMiddleware:
    - name: sap-fe-mockserver
      beforeMiddleware: compression
      configuration:
        service:
          ...

I would like to be able to run e.g. ui5 serve --config ui5.yaml --config mockserver.yaml and have the two config files effectively merged into one configuration.

Describe alternatives you've considered

  • catting the config files together and passing it to ui5, but besides being wonky, the UI5 CLI doesn't support passing configuration on stdin
  • pasting the two configs into a new file using a pre-run NPM script, passing that to ui5 serve, deleting it afterwards (also not great)

Activity

  1. RandomByte commented on Dec 6, 2022

    @RandomByte
    Member

    Thanks for filing this feature request. Am I understanding it correctly that the two files contain configuration for the same project (the application)?

    A ui5.yaml file can contain multiple configurations (e.g. multiple projects, extensions, etc), so we need to be careful which configurations should be merged.

  2. jakubledl commented on Jan 3, 2023

    @jakubledl
    Author

    Hello @RandomByte, that is correct! I understand further thought needs to be given to the question you mention, when one has multiple documents/configuration in a single document, but perhaps the most straightforward solution could be not to support this case (i.e. return an error when one of the files to be merged contains multiple YAML documents) and only allow merging of single-document files?

  3. matz3 commented on Jan 4, 2023

    @matz3
    Member

    To merge multiple documents, the metadata.name could be used as key to identify the right document.
    I would at least expect those fields (specVersion, metadata, type) to be mandatory (also to be able to use the schema validation).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions