Skip to content

Fix https://github.com/Microsoft/TypeScript/issues/11870: Do not failon empty file list diagnostic messages - #226

Merged
blakeembrey merged 1 commit into
TypeStrong:masterfrom
mhegazy:Fix11870
Oct 27, 2016
Merged

blakeembrey merged 1 commit into
TypeStrong:masterfrom
mhegazy:Fix11870

Conversation

@mhegazy

@mhegazy mhegazy commented Oct 26, 2016

Copy link
Copy Markdown
Contributor

Originally reported in microsoft/TypeScript#11870.

Change microsoft/TypeScript#11743 added a new error for TS 2.1 if the files list is empty, or include+exclude result in an empty set.
This breaks usage of ts-node.

@blakeembrey I could not find a better solution here, so appreciate your guidance.

@coveralls

coveralls commented Oct 26, 2016 •

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.04%) to 86.402% when pulling b65f5f8 on mhegazy:Fix11870 into 5831ef4 on TypeStrong:master.

@blakeembrey

Copy link
Copy Markdown
Member

Thanks. I think this looks good, I'll merge this and make a new release ASAP, sounds like TypeScript relies on it. I didn't expect that feature to be used like that 😄

FWIW, would it make more sense for these sorts of checks to be done at a higher level like the CLI/server instead? I think this will be an edge-case that'll come up for every compiler tool such as ts-loader, tsify, etc. I've run into a few of these API idiosyncrasies now and it makes a tricky exercise for someone new to use the APIs effectively.

Also, the original issue (microsoft/TypeScript#11621) isn't really solved by this as one might have a single file in src/ and still run into the issue. Perhaps tooling/VS Code could make it more obvious which configuration file is in use (I imagine this feature would be similar to selecting which tsconfig.json to use as a manual override - where it defaults to saying "none selected" or "not in project" (which is what Atom does) - since tsc can accept custom paths to a config file)?

@blakeembrey
blakeembrey merged commit a12cb44 into TypeStrong:master Oct 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants