Skip to content

Update Bruss for a new release of DiffEqOperators.jl #49

Open

Activity

  1. kanav99 commented on Aug 8, 2019

    @kanav99
    Contributor

    Should we make a constructor of DerivativeOperator instead that acts as compatibility for such cases? We don't even have this stuff documented and this kind of change is scary.

  2. ChrisRackauckas commented on Aug 10, 2019

    @ChrisRackauckas
    Member

    should it even use the DerivativeOperator?

  3. kanav99 commented on Aug 10, 2019

    @kanav99
    Contributor

    I just replaced

    DerivativeOperator{Float64}(2,2,1/(N_brusselator_1d-1),
                                          N_brusselator_1d,
                                          :Dirichlet,:Dirichlet;
                                          BC=(1.,1.))

    with

    CenteredDifference{Float64}(2,2,1/(N_brusselator_1d-1),N_brusselator_1d)

    and it worked for OrdinaryDiffEq tests. Is it right?

  4. ChrisRackauckas commented on Aug 10, 2019

    @ChrisRackauckas
    Member

    yes that's good. PR.

  5. ChrisRackauckas commented on Aug 10, 2019

    @ChrisRackauckas
    Member

    Still not completely fixed since I forgot it needs BCs as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions