Repository navigation
Conversation
Temporarily ignore some extensions for PHP 8.6.0 (until they're fixed).
| --enable-libwebpdemux \ | ||
| --enable-libwebpmux | ||
|
|
||
| make -j8 |
| skip=( "imap" "igbinary" ) | ||
|
|
||
| echo "Compile the extensions for PHP $php_version" | ||
| skip84=( "imap" ) |
There was a problem hiding this comment.
suggestion: add _ge to make it more explicit that it's for version greater or equal than 8.4
| skip84=( "imap" ) | |
| skip_ge_84=( "imap" ) |
| echo "----- Compile PHP extensions from ext for PHP $php_version" | ||
| echo | ||
|
|
||
| # SKIP igbinary extension since it doesn't compile with PHP 8.5 |
There was a problem hiding this comment.
question: only for 8.5? Or also for 8.6?
There was a problem hiding this comment.
We also skip it for 8.6 unfortunately.
I guess renaming the vars to $skip_ge_8* makes it clearer.
(for now we don't have the case where an extension wouldn't be available for 8.n and not 8.n-1)
There was a problem hiding this comment.
I have also updated the comment in 74347ad
| # SKIP imagick extension | ||
| # | ||
| # SKIP mcrypt extension | ||
| # | ||
| # SKIP memcached extension | ||
| # | ||
| # SKIP mongodb extension |
There was a problem hiding this comment.
suggestion: add a word to explain why it does not work. I assume you didn't add anything because there is no upstream issue. Maybe add tthe error message here? Or open an issue upstream so that we can link it here?
| if [[ "${PHP_MODULE_API_VERSIONS["${php_version}"]}" -ge 20240924 ]] \ | ||
| && [[ ${skip[@]} =~ "${ext_name}" ]] | ||
| # Skip some extensions for PHP >= 8.5 | ||
| if [[ "${PHP_MODULE_API_VERSIONS["${php_version}"]}" -ge 20250925 ]] \ |
There was a problem hiding this comment.
suggestion: we usually rather write PHP_MODULE_API_VERSIONS["8.5"] rather than 20250925. It's much clearer. WDYT?
There was a problem hiding this comment.
Ah yes, of course 🤦♂️
Following code review and suggestions by @EtienneM.
- Also deprecate mcrypt
Related to #639
eventto3.2.0andmongodbto1.21.14.Packages have been uploaded to ObjectStorage for:
scalingo-22scalingo-24scalingo-26Tested here: https://fku-dummy.osc-st-fr1.apps.st-sc.fr