Skip to content

feat: add documentation for redis_to_valkey_migration_completed - #3987

Open
EtienneM wants to merge 2 commits into
masterfrom
feat/STORY-4235/redis_valkey_migration_completed
Open

EtienneM wants to merge 2 commits into
masterfrom
feat/STORY-4235/redis_valkey_migration_completed

Conversation

@EtienneM

Copy link
Copy Markdown
Member

No description provided.

@EtienneM EtienneM self-assigned this Sep 25, 2026
@notion-workspace

Copy link
Copy Markdown

@EtienneM
EtienneM marked this pull request as ready for review September 25, 2026 06:58
@Scalingo Scalingo deleted a comment from notion-workspace Bot Sep 25, 2026
@EtienneM
EtienneM requested review from a team and matthieu526-scalingo and removed request for a team September 25, 2026 06:58
| `collaborator_invited` | Collaborator invited | A collaborator was invited |
| `collaborator_removed` | Collaborator removed | A collaborator was removed |
| `collaborator_role_changed` | Collaborator role changed | A collaborator role was changed |
| `complete_redis_to_valkey_migration` | Redis to Valkey migration completed | A migration from Redis to Valkey completed |

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: is it properly aligned, or is it a GH display issue? When I look at the raw file it's not a nice table.

@Frzk Frzk Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question(non-blocking): Why not redis_to_valkey_migration_completed?
I feel like the state of the migration is a bit more clear using this form, don't you think?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: is it properly aligned, or is it a GH display issue?

It wasn't properly aligned. I updated it so that the alignment is correct.

question(non-blocking): Why not redis_to_valkey_migration_completed?

You are right, your event name is better than mine. I updated it.

@EtienneM
EtienneM force-pushed the feat/STORY-4235/redis_valkey_migration_completed branch from cc1e0a0 to 2ffca2c Compare September 28, 2026 09:25
| `variable_bulk_edited` | Variables bulk edited | Some variables was bulk edited |
| `variable_edited` | Variable edited | A variable was edited |
| `variable_removed` | Variable removed | A variable was removed |
| Event Type | Display Name | Description |

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whole table changed because I formatted again the table

@EtienneM EtienneM changed the title feat: add documentation for complete_redis_to_valkey_migration feat: add documentation for redis_to_valkey_migration_completed Sep 30, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants