Repository navigation
fix(dbdr): resolve databases by name or ID - #1278
WilliamK112 wants to merge 6 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex review |
5cbc2b2 to
596e9ae
Compare
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Ching-Wei Kang <ckang53@wisc.edu>
EtienneM
left a comment
There was a problem hiding this comment.
For consistency purpose, I actually think that all DBNG commands should be able to use the DB name or the DB ID.
|
Fixed the Validation: |
|
Expanded the fix as requested so every DBNG command that targets an existing database now accepts either its exact name or ID. The shared resolver supplies canonical IDs to info/config/upgrade/destroy and networking operations, while firewall commands resolve the corresponding app and addon identifiers. I also updated the help text and added addon-selection coverage. Validation passed: |
# Conflicts: # cmd/databases_dr.go # cmd/databases_networking.go # cmd/firewall_rules.go # dbdr/database.go # dbdr/destroy_test.go
|
Merged the latest |
Summary
Closes #1273
Validation
go test ./...go test -race ./dbdr ./cmdgo vet ./...git diff --checkAdd a changelog entry in the section "To Be Released" of CHANGELOG.md
AI assistance
Codex assisted with drafting the implementation and tests. I reviewed the diff and verified it with the full Go test suite, race detection for the affected packages, and go vet.