Repository navigation
fix: XSUAA Usage in Spring Boot Archetype - #167
Merged
Merged
Conversation
MatKuhr
added
please merge
Johannes-Schneider
previously approved these changes
Nov 30, 2023
Johannes-Schneider
left a comment
Johannes-Schneider
left a comment
Contributor
There was a problem hiding this comment.
Apart from the duplicated import - LGTM!
Comment on lines
-40
to
-46
| <dependency> | ||
| <groupId>com.sap.cloud.security</groupId> | ||
| <artifactId>java-bom</artifactId> | ||
| <version>${security-lib.version}</version> | ||
| <scope>import</scope> | ||
| <type>pom</type> | ||
| </dependency> |
Contributor
There was a problem hiding this comment.
(note to myself - and anyone who might be wondering)
This isn't needed as we are already including the XSUAA bom in our bom.
…/integration-tests/src/test/java/__packageInPathFormat__/HelloWorldControllerTest.java
Johannes-Schneider
approved these changes
Nov 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Follow-up of #164 and #166
Compare this and this change on V4.
Successful E2E Test Run