Repository navigation
fix: DwC Connectivity Service Auto Configuration - #149
Merged
Merged
Conversation
MatKuhr
added
do not merge
newtork
reviewed
Nov 20, 2023
Johannes-Schneider
suggested changes
Nov 21, 2023
MatKuhr
enabled auto-merge (squash)
November 21, 2023 16:40
Johannes-Schneider
approved these changes
Nov 22, 2023
Johannes-Schneider
left a comment
Johannes-Schneider
left a comment
Contributor
There was a problem hiding this comment.
Changes LGTM - I think we should start something like a release_notes_dwc_next_snapshot.md to keep track of (future) changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
SAP/cloud-sdk-java-backlog#209
This PR changes the connectivity service binding for megaclite to no longer be registered by default. This is necessary as otherwise there would be two bindings available in case shared orbits are used.
Users will have to register the connectivity binding explicitly, similar to the destination service binding.
Feature scope:
CONNECTIVITY_BINDINGpublicDefinition of Done
Error handling created / updated & covered by the tests aboveRelease notes updated