Repository navigation
Conversation
The SWIFT IBAN registry gives Costa Rica 22 characters (CR2!n4!n14!n); its version 60 had 21. Iban still expected 21, so it rejected every 22-character Costa Rican IBAN and accepted 21-character ones with a valid checksum.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1894 +/- ##
=========================================
Coverage 97.18% 97.18%
Complexity 1096 1096
=========================================
Files 198 198
Lines 2555 2555
=========================================
Hits 2483 2483
Misses 72 72 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1893.
COUNTRIES_LENGTHShad 21 for Costa Rica. The SWIFT IBAN registry structure went fromCR2!n3!n14!n(21 characters, version 60) toCR2!n4!n14!n(22 characters, version 69), and Symfony's table, generated from the current registry, also has 22. The Banco Central de Costa Rica gives the same length.Ibanrejected every 22-character Costa Rican IBAN and accepted 21-character ones whose checksum was right. After this change, those 21-character values are rejected.Tests
CR05 0152 0200 1026 2840 66, the example in version 69 of the registry.CR05 1520 2001 0262 8406 6, the example in version 60. Its checksum is right, so only the length check rejects it.Both cases fail on
mainand pass with this change.composer qapasses.This line sits between two lines that #1892 adds, so whichever of the two PRs is merged second will need a rebase. I'll do it.