Repository navigation
Conversation
tdhock
commented
Nov 13, 2026
Generated via commit d20686a Download link for the artifact containing the test results: ↓ atime-results.zip
|
Member
Author
|
@MichaelChirico could you please review? (you reviewed the last PR on this file, #7901 ) |
aitap
reviewed
Nov 17, 2026
Member
There was a problem hiding this comment.
Secrets are not passed to the runner when a workflow is triggered from a forked repository, so this should be safe.
Maybe the "Post or update PR comment" step should be skipped completely when running for a PR from a fork?
See also this series of blog posts
Member
Author
|
Good idea Ivan. Does artifact upload also fail for forks? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

In atime comments we see (Plot image upload to picrd.com failed; download the artifact below to view plots).
This is caused by 401 error from picrd (unauthorized).
Apparently picrd needs an api key now, so I signed up for one, and added it as a repo Actions secret.