Skip to content

capture missing() of arguments once as flags in [ - #7932

Merged
ben-schwen merged 2 commits into
brk/a1_testsfrom
brk/a2_missing_flags
Nov 3, 2026
Merged

ben-schwen merged 2 commits into
brk/a1_testsfrom
brk/a2_missing_flags

Conversation

@ben-schwen

Copy link
Copy Markdown
Member

Towards #852

@codecov

codecov Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.09%. Comparing base (2f7421f) to head (72a5526).

Additional details and impacted files
@@              Coverage Diff              @@
##           brk/a1_tests    #7932   +/-   ##
=============================================
  Coverage         99.09%   99.09%           
=============================================
  Files                88       88           
  Lines             17429    17439   +10     
=============================================
+ Hits              17271    17281   +10     
  Misses              158      158           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ben-schwen
ben-schwen force-pushed the brk/a2_missing_flags branch from 353fbce to a8fcf6a Compare October 21, 2026 12:07
@ben-schwen
ben-schwen force-pushed the brk/a2_missing_flags branch 2 times, most recently from cba9c55 to 391abec Compare October 24, 2026 23:13
@github-actions

github-actions Bot commented Oct 24, 2026 •

Copy link
Copy Markdown
  • HEAD=brk/a2_missing_flags much slower for as.data.table.array improved in #7019
  • HEAD=brk/a2_missing_flags much slower for DT[i,j,by] per-call overhead for #852
  • HEAD=brk/a2_missing_flags faster P<0.001 for melt(list measure.vars, variable.factor=FALSE) improved in #7917

(Plot image upload to picrd.com failed; download the artifact below to view plots)

Generated via commit 72a5526

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 1 minutes and 4 seconds
Installing different package versions 18 seconds
Running and plotting the test cases 5 minutes and 2 seconds

Comment thread R/data.table.R Resolved
@ben-schwen
ben-schwen force-pushed the brk/a2_missing_flags branch from 391abec to 8e8d36b Compare October 26, 2026 15:13
missing() works in the calling frame so it blocks moving code out of [.data.table.
Capture it once at the top as missing_<arg> flags and keep them in sync where an argument is reassigned.

No behaviour change.
@ben-schwen
ben-schwen force-pushed the brk/a2_missing_flags branch from 8e8d36b to 32ecc72 Compare November 1, 2026 21:02
@ben-schwen
ben-schwen removed this pull request from stack #7933 November 3, 2026 09:15
@ben-schwen
ben-schwen added this pull request to stack #7953 November 3, 2026 09:16
@ben-schwen
ben-schwen merged commit 3e47560 into bracket_modularization Nov 3, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants