Skip to content

OSS-Fuzz: Add new fuzzer/corpus/dict targets ifs reader - #6528

Open
arthurscchan wants to merge 1 commit into
PointCloudLibrary:masterfrom
arthurscchan:pcl-ifs-reader
Open

arthurscchan wants to merge 1 commit into
PointCloudLibrary:masterfrom
arthurscchan:pcl-ifs-reader

Conversation

@arthurscchan

@arthurscchan arthurscchan commented Nov 13, 2026 •

Copy link
Copy Markdown

This PR creates a new OSS-Fuzz fuzzer with corpus and dict targets ifs reader, aiming to enable a new fuzzer for improving the overall fuzzing coverage and effectiveness of project pcl.

Summary by CodeRabbit

  • Tests
    • Added fuzz testing for IFS file reading, with generated seed files and a dictionary to exercise cloud and mesh inputs.

Signed-off-by: Arthur Chan <arthur.chan@adalogics.com>
@coderabbitai

coderabbitai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The pull request adds an IFS reader fuzz target, four generated seed files, and an IFS token dictionary. The build script compiles the target, creates a ZIP archive of the seeds, and copies the dictionary to the fuzzing output directory.

Changes: IFS Reader Fuzzing

Layer / File(s) Summary
Seed corpus and dictionary
test/fuzz/gen_ifs_seeds.py, test/fuzz/ifs_reader_fuzzer.dict
The generator writes four IFS seed layouts to the selected directory. The dictionary adds the IFS, VERTICES, and TRIANGLES tokens.
Reader harness and build integration
test/fuzz/ifs_reader_fuzzer.cpp, test/fuzz/build.sh
The fuzz target writes each input to a temporary file and calls both IFSReader overloads. The build script compiles the target, generates and packages the seeds, and copies the dictionary to $OUT.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Sequence Diagram(s)

sequenceDiagram
  participant LibFuzzer
  participant IFSReaderFuzzer
  participant TemporaryFile
  participant IFSReader
  LibFuzzer->>IFSReaderFuzzer: pass input bytes
  IFSReaderFuzzer->>TemporaryFile: write input
  IFSReaderFuzzer->>IFSReader: read as PCLPointCloud2 and PolygonMesh
  IFSReaderFuzzer->>TemporaryFile: unlink file
Loading
Merge Risk: Minimal · up to 56380

This change adds an IFS reader fuzz target with seeds and a dictionary under test/fuzz. It does not alter runtime behavior of the library, so merge risk is minimal.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title names the change: adding OSS-Fuzz fuzzer, corpus, and dictionary targets for the IFS reader. The changeset adds test/fuzz/ifs_reader_fuzzer.cpp (LLVMFuzzerTestOneInput target reading IFS fil…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the change: adding OSS-Fuzz fuzzer, corpus, and dictionary targets for the IFS reader. The changeset adds test/fuzz/ifs_reader_fuzzer.cpp (LLVMFuzzerTestOneInput target reading IFS files via pcl::IFSReader), test/fuzz/gen_ifs_seeds.py (seed corpus generator), test/fuzz/ifs_reader_fuzzer.dict (dictionary), and test/fuzz/build.sh (build, seed packaging, and dictionary copy). The title matches the main change. It uses the 'OSS-Fuzz:' prefix and a slightly awkward phrase ('ifs reader' without 'IFS' capitalization or a connecting word), but the meaning is clear.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 0c897daa-2342-411b-aee9-81a9dfc43fab
Commits

Reviewing files that changed from the base of the PR and between 3aac7b6 and 563808d.

Files selected for processing: 4

  • test/fuzz/build.sh
  • test/fuzz/gen_ifs_seeds.py
  • test/fuzz/ifs_reader_fuzzer.cpp
  • test/fuzz/ifs_reader_fuzzer.dict

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant