This repository was archived by the owner on Mar 21, 2024. It is now read-only.
Repository navigation
Fix some min/max macro collisions with windows.h - #1552
Merged
Merged
Conversation
alliepiper
requested review from
gevtushenko
and removed request for
gevtushenko
October 25, 2021 21:37
alliepiper
marked this pull request as draft
October 25, 2021 22:03
Contributor
Author
|
Marking draft -- there are some issues with these macros I'll need to address before review. |
alliepiper
force-pushed
the
enable_min_max_tests
branch
2 times, most recently
from
October 26, 2021 02:59
7502661 to
c9aa41e
Compare
Contributor
Author
|
DVS CL: 30576591 run tests |
alliepiper
force-pushed
the
enable_min_max_tests
branch
from
October 26, 2021 15:09
c9aa41e to
da46adc
Compare
Contributor
Author
|
DVS CL: 30579235 run tests |
Contributor
Author
|
This may not be doable...some standard library headers are now emitting errors from their usages of min/max. |
alliepiper
force-pushed
the
enable_min_max_tests
branch
2 times, most recently
from
February 7, 2022 20:04
bcb2a2d to
2f1e928
Compare
alliepiper
changed the title
Contributor
Author
alliepiper
marked this pull request as ready for review
February 7, 2022 20:18
alliepiper
added
testing: gpuCI in progress
gevtushenko
approved these changes
Feb 8, 2022
alliepiper
added
testing: gpuCI passed
alliepiper
force-pushed
the
enable_min_max_tests
branch
from
February 8, 2022 16:16
2f1e928 to
a32df53
Compare
Tried adding these to the header test macro checks, but this introduced new issues on non-msvc builds. We can revist the header tests later, this PR just fixes the collisions.
alliepiper
force-pushed
the
enable_min_max_tests
branch
from
February 8, 2022 16:19
a32df53 to
4cdde3b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.