Repository navigation
JSON defined jit lto kernels - #3030
Draft
robertmaynard wants to merge 2 commits into
Draft
robertmaynard wants to merge 2 commits into
robertmaynard wants to merge 2 commits into
Conversation
robertmaynard
added
feature request
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Replace the 56 inline generate_jit_lto_kernels calls with one JSON file per kernel family and a generate_jit_lto_kernel_collection wrapper built on rapids_json_array_items and rapids_json_parse. The wrapper calls the existing rtcx generate_jit_lto_kernels unchanged, and the arguments of all 56 calls are identical to before.
Replace the 33 generate_inst_matrix calls in cpp/CMakeLists.txt with inst_matrix.json files, one per matrix directory, that are expanded by generate_inst_matrix_collection. The generated files are collected in a single cuvs_inst_files list, with the multi-GPU instantiations kept in their own file so they are only generated when BUILD_MG_ALGOS is on. Also have generate_jit_lto_kernel_collection check its required members itself, and ask rapids_json_array_items for the JSON file directory.
robertmaynard
force-pushed
the
fea/json_defined_jit_lto_kernels
branch
from
November 9, 2026 20:02
4939cc8 to
c9da0cd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use functionality added in rapidsai/rapids-cmake#1116 to simplify the CMakeLists.txt for cuVS.
Added benifit of moving to JSON files for this work, is that we can remove a
cuvs-cmake-codeownersreview for PRs that just add or remove LTO files.