Repository navigation
[ENHANCEMENT]: Update build-time check since the trunk CCCL allows 1B/2B atomic_ref #554
Description
Is your feature request related to a problem? Please describe.
https://godbolt.org/z/a78x4qrha
Originally posted by @sleeepyjack #549 (comment)
Now cuda::atomic_ref can work with 1-byte and 2-byte variables so we need to update the static asserts accordingly in cuco data structures, e.g.
cuCollections/include/cuco/static_map_ref.cuh
Lines 77 to 78 in a7f87ac
Describe the solution you'd like
Update build checks and unit tests
Describe alternatives you've considered
No response
Additional context
No response
Activity
sleeepyjack commentedon Jul 22, 2024
Having the same build time checks all over the library isn't ideal. Maybe this is an opportunity to refactor this whole insertion logic into a separate struct
slot_inserterthat internally decides which insertion strategy to use and also checks if the input types can be handled at all. Let me draft something in Godbolt.sleeepyjack commentedon Jul 22, 2024
Something like this: https://godbolt.org/z/nvGGYaPWa
This would also solve #547