Repository navigation
Keep RETURNING working through the dialect query analyzer - #351
Open
jayhemnani9910 wants to merge 1 commit into
Open
jayhemnani9910 wants to merge 1 commit into
jayhemnani9910 wants to merge 1 commit into
Conversation
classify_query only looked at the first keyword, so UPDATE ... RETURNING went down the non-query path and SQLite failed on commit.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UPDATE ... RETURNINGandINSERT ... RETURNINGon SQLite fail withcannot commit transaction - SQL statements in progress, and the write is lost. #219 added the RETURNING check toKeywordQueryAnalyzer, but real queries go throughDialectQueryAnalyzer, which asks the adapter, andclassify_queryonly looked at the first keyword.classify_querynow returns true for DML withRETURNING.--format json|csv --limit 0streams from the cursor and never commits, so that path now skips DML and uses the normal one.Before,
update t set price=9 where id=1 returning id,priceerrored and left the row unchanged. After, it prints the row and the change is saved, also with--limit 0 --format json. New tests fail without the change.pytest tests/unit tests/clipasses.